Repository navigation
Enable NativeAOT delegate function-pointer tests - #133401
Merged
MichalStrehovsky merged 1 commit intoSep 9, 2026
Merged
MichalStrehovsky merged 1 commit into
MichalStrehovsky merged 1 commit into
Conversation
Remove the misplaced IDispatch exclusion from TestFunctionPointer. The separate COM test remains gated on IsBuiltInComEnabled. Co-authored-by: Copilot <[email protected]> Copilot-Session: 3dea65e4-6bec-47a1-b938-b02f43d8a0bb
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a targeted removal of an inapplicable skip attribute and does not alter test logic or introduce new behavior beyond enabling the intended test to run on NativeAOT.
Pull request overview
This PR removes a NativeAOT-gated [ActiveIssue] attribute from TestFunctionPointer, allowing the delegate-as-function-pointer interop test to execute under NativeAOT. The IDispatch/COM-related coverage remains isolated to TestIDispatch (which uses [MarshalAs(UnmanagedType.IDispatch)] and native IDispatch* interop).
Changes:
- Remove the
runtimelab#176: IDispatch[ActiveIssue(..., Utilities.IsNativeAot)]exclusion fromTestFunctionPointer.
File summaries
| File | Description |
|---|---|
| src/tests/Interop/PInvoke/Delegate/DelegateTest.cs | Stops skipping the function-pointer delegate interop test on NativeAOT by removing a misplaced IDispatch-related ActiveIssue attribute. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
jkotas
approved these changes
Sep 8, 2026
Member
Author
|
/ba-g mono crash was known |
MichalStrehovsky
enabled auto-merge (squash)
September 9, 2026 05:10
MichalStrehovsky
deleted the
fix/nativeaot-delegate-function-pointers
branch
September 9, 2026 05:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves dotnet/runtimelab#176.
Remove the misplaced IDispatch exclusion from TestFunctionPointer.