Repository navigation
Track NativeAOT BestFitMapping failures with a dedicated issue - #133396
Merged
MichalStrehovsky merged 1 commit intoSep 9, 2026
Merged
MichalStrehovsky merged 1 commit into
MichalStrehovsky merged 1 commit into
Conversation
Point the NativeAOT exclusion at dotnet#133395 instead of the general limitations issue. Co-authored-by: Copilot <[email protected]> Copilot-Session: 3dea65e4-6bec-47a1-b938-b02f43d8a0bb
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward update to the ActiveIssue tracking link and is consistent with the stated goal of tracking NativeAOT BestFitMapping failures via a dedicated dotnet/runtime issue.
Pull request overview
This PR updates the NativeAOT skip-tracking for the BestFitMapping interop test by pointing its ActiveIssue attribute at a dedicated dotnet/runtime issue, so failures are tracked in the primary repo rather than runtimelab.
Changes:
- Replace the NativeAOT
ActiveIssueURL in the BestFitMapping test entrypoint todotnet/runtime#133395.
File summaries
| File | Description |
|---|---|
| src/tests/Interop/PInvoke/BestFitMapping/Program.cs | Updates the NativeAOT ActiveIssue link to a dedicated runtime issue for tracking BestFitMapping failures/crash. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
jkotas
approved these changes
Sep 8, 2026
Member
Author
|
/ba-g mono crash was #133442 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test looks to be hitting some legit bugs (not just throwing the "Marshalling not supported").