Repository navigation
Narrow browser WASM R2R test exclusions - #133310
Conversation
Co-authored-by: Copilot App <[email protected]>
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
There was a problem hiding this comment.
🟡 Changes recommended
One change makes a test silently pass via early-return when Assembly.Location is empty; it should be an explicit skip (or fail-fast outside the intended platform) to avoid masking regressions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This pull request narrows browser-WASM ReadyToRun (R2R) test suppressions to specific known-failing scenarios so the R2R lane can be re-enabled while preserving coverage elsewhere.
Changes:
- Skip the
TestGenericMDArrayBehaviorcrossgen2 smoke subtest only for browser + R2R execution. - Apply method-level
ActiveIssueconditions for specific xUnit regression tests that fail only under browser + R2R. - Mark
TypeMapAppas R2R-incompatible only for CoreCLR browser builds to avoid crossgen2 compile-time failure.
File summaries
| File | Description |
|---|---|
| src/tests/readytorun/crossgen2/Program.cs | Conditionally avoids running the generic MD-array behavior test under browser R2R. |
| src/tests/JIT/Regression/JitBlue/Runtime_79354/Runtime_79354.cs | Adds ActiveIssue gating for browser R2R. |
| src/tests/JIT/Regression/JitBlue/Runtime_58874/Runtime_58874.cs | Adds ActiveIssue gating for browser R2R. |
| src/tests/JIT/Regression/JitBlue/Runtime_117566/Runtime_117566.cs | Avoids LoadFromAssemblyPath when Assembly.Location is empty. |
| src/tests/JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b125091/b125091.il | Adds ActiveIssue gating for browser R2R in the IL test. |
| src/tests/Interop/TypeMap/TypeMapApp.csproj | Marks the TypeMap test app as R2R-incompatible only for CoreCLR browser builds. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Lite
Co-authored-by: Copilot App <[email protected]>
|
I opened #133308 to allow testing against partial disabling while we work through the issues |
lewing
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
Co-authored-by: Copilot App <[email protected]>
There was a problem hiding this comment.
🟡 Changes recommended
The new browser+R2R guard skips the entire TestGenericMDArrayBehavior test (multiple sub-checks), which is broader than the intended “single failing subtest” suppression and unnecessarily drops coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Lite
Co-authored-by: Copilot App <[email protected]>
Co-authored-by: Copilot App <[email protected]>
There was a problem hiding this comment.
🟡 Changes recommended
Interop.csproj’s new R2RIncompatible condition currently applies to all CoreCLR WASM targets (not browser-only), which conflicts with the stated intent and risks dropping WASI R2R coverage unintentionally.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Lite
|
/azp run runtime-wasm-non-libtests |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped to test gating/infrastructure for known WASM R2R failures, with only a minor maintainability improvement suggested around making the smoke-test skip explicit in output.
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Lite
Summary
Narrowly suppress the confirmed WASM ReadyToRun failure shapes tracked by #131886, #133259, #133303, and #133307 so the browser R2R lane can be restored without losing interpreter or unaffected-platform coverage.
ActiveIssueconditions forRuntime_79354andRuntime_58874, scoped to WASM R2RAssembly.Locationas an unsupported premise inRuntime_117566, following review feedback from [WIP] Fix test failure for Regression_o_2 browser-wasm R2R incompatibilities #133274Interopwork item R2R-incompatible on CoreCLR Wasm because Crossgen2 aborts before execution while resolvingTypeMapAppmetadataPlatformDetection.IsWasmandPlatformDetection.IsReadyToRunCompiledThis intentionally does not suppress #133219, #133221, #133224, #133286, or the remaining unclassified failure shapes in #133305. Exact-base R2R evidence shows
b125091now passes, and the current-main R2R baseline also showspinnedlocalpassing when reached.Testing
b125091passedRuntime_79354,Runtime_117566,Runtime_58874, and generic multidimensional-array R2R failures while their interpreter controls passedRuntime_117566empty-location guard on WASI made both interpreter and R2R executions passInteropcomposite aborts before execution whileTypeMapAppindividually compiles and passesInteropwith the parentR2RIncompatibleproperty: interpreter ran 57/57 and R2R skipped before compilation with exit 0Interopexclusion is set for browser-wasm and wasi-wasm but unset for native targetsThe broader WASI work items remain outside the curated lane:
Regression_o_3has three additionalAssembly.Locationfailures, andRegression_1later aborts incsharptester, even thoughb125091itself passes.Note
This pull request was created with GitHub Copilot assistance.