Repository navigation
[WIP] Fix assertion failed during remove empty try-catch-fault - #133103
Conversation
|
Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Co-authored-by: AndyAyersMS <[email protected]>
|
@EgorBo PTAL |
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
🔵 Needs a closer look
The change touches subtle JIT flowgraph ref-count invariants in EH optimization and should get a maintainer’s final correctness review across configurations/architectures.
Pull request overview
Fixes a ref-counting invariant in the JIT’s empty try/catch/fault removal phase by accounting for additional refs to the handler/filter entry block (e.g., from internal back-edges), and adds a focused regression test to cover the scenario.
Changes:
- Update
fgRemoveEmptyTryCatchOrTryFaultto decrement (rather than assert-equal/set-to-zero) the artificialbbRefson filter/handler entry blocks. - Add a new JIT regression test reproducing the handler-entry back-edge case.
- Wire the new regression test into the
Regression_ro_2merged test project.
File summaries
| File | Description |
|---|---|
| src/coreclr/jit/fgehopt.cpp | Adjusts handler/filter entry bbRefs bookkeeping to tolerate internal back-edges when removing empty try regions. |
| src/tests/JIT/Regression/JitBlue/Runtime_133101/Runtime_133101.cs | Adds a targeted regression test exercising the loop-in-finally-entry shape. |
| src/tests/JIT/Regression/Regression_ro_2.csproj | Includes the new regression test in the merged runner project. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
|
/ba-g one of the build monitors is confused. |
|
It looks like the build monitor failure was real but wasn't showing up in the Tests tab. I'm also hitting it in an otherwise green run. |
Uh oh!
There was an error while loading. Please reload this page.