Repository navigation
Update code review skill to not point out public APIs in tools - #133064
Merged
Merged
Conversation
AI pointing these out in tools is annoying (most recent here: #131877 (comment)).
|
Azure Pipelines: Successfully started running 1 pipeline(s). 15 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
lewing
approved these changes
Sep 2, 2026
agocke
approved these changes
Sep 2, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, scoped to reviewer guidance, and aligns with the stated goal; only a minor clarity tweak is suggested.
Pull request overview
This PR updates the dotnet/runtime code-review skill guidance so “detect new public API surface” checks don’t incorrectly treat public C# types in tool code as shipping public API.
Changes:
- Narrows the “new
publicmembers” heuristic to focus onsrc/librariesrather than allsrc/. - Adds clarifying guidance that
tools/subdirectories contain tool code whosepublicsurface should not be treated as public API.
File summaries
| File | Description |
|---|---|
| .github/skills/code-review/SKILL.md | Refines API-surface detection guidance to avoid flagging tool code as public API. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI pointing these out in tools is annoying (most recent here: #131877 (comment)).
Cc @dotnet/appmodel