JIT: add JitEnablePhaseChecks, and disable it for the base SuperPMI asm diffs JIT - #132822

Suppressed comments (5)

Previously missed (2) — in code that hasn't changed since the last review.

src/coreclr/scripts/superpmi.py:5746

• The warning for specifying both -full_ir_checks and -no_ir_checks currently ignores -no_ir_checks, but the option's help and comments describe -no_ir_checks as disabling checks everywhere. Either make the options mutually exclusive (error) or have -no_ir_checks take precedence (e.g., ignore -full_ir_checks).
  src/coreclr/scripts/superpmi.py:351
• The new JitEnablePhaseChecks knob gates all post-phase checks (flow graph, loops, uniqueness, profile, IR, etc.), not just IR checks. The -no_ir_checks help text is misleading; it should describe disabling post-phase checks rather than only "phase IR checks".

This issue also appears in the following locations of the same file:

• line 380
• line 2216

src/coreclr/scripts/superpmi.py:380

• Similar to -no_ir_checks, -full_ir_checks controls JitEnablePhaseChecks, which gates all post-phase checks, not only IR checks. The help text should avoid calling these "phase IR checks" to prevent confusion about what is being disabled/enabled.

asm_diff_parser.add_argument("-full_ir_checks", action="store_true", help="Run the phase IR checks in the base JIT as well. By default they are only run in the diff JIT, since the base JIT is already validated.")

src/coreclr/jit/jitconfigvalues.h:199

• The JitEnablePhaseChecks config gates all post-phase checks (not only IR checks). The comment should reflect that broader scope so it's clear what behavior this config controls.

CONFIG_INTEGER(JitEnablePhaseChecks, "JitEnablePhaseChecks", 1) // Run the phase IR checks

src/coreclr/scripts/superpmi.py:2220

• This comment block repeatedly refers to "phase IR checks", but the new JitEnablePhaseChecks toggle actually gates all post-phase checks, not only IR. Updating the wording here will help prevent misunderstandings about what the new flags/config control.

        # The base JIT is already validated, so the phase IR checks are turned off for it by
        # default and left on for the diff JIT, which is the one under test. -full_ir_checks
        # turns them back on for the base JIT, and -no_ir_checks turns them off everywhere.
        #
        # The diff artifact runs compare the base and diff JitDumps textually, so the checks

• Files reviewed: 4/4 changed files
• Comments generated: 1
• Review effort level: Lite

Suppressed comments (4)

Previously missed (1) — in code that hasn't changed since the last review.

src/coreclr/scripts/superpmi.py:5748

• This warning currently uses print(), which bypasses the script's logging configuration (log file, timestamps, etc.). Using logging.warning keeps output consistent with other warnings in this script.

src/coreclr/scripts/superpmi.py:380

• -full_ir_checks is described as enabling "phase IR checks" in the base JIT, but JitEnablePhaseChecks actually gates all post-phase checks controlled by activePhaseChecks (not only IR). Updating the option help text to match the actual behavior will make this flag clearer.

asm_diff_parser.add_argument("-full_ir_checks", action="store_true", help="Run the phase IR checks in the base JIT as well. By default they are only run in the diff JIT, since the base JIT is already validated.")

src/coreclr/scripts/superpmi.py:2222

• This comment block uses the term "phase IR checks", but the new JitEnablePhaseChecks gating affects all post-phase checks driven by activePhaseChecks. Consider updating the terminology here to avoid implying only IR validation is affected.

        # The base JIT is already validated, so the phase IR checks are turned off for it by
        # default and left on for the diff JIT, which is the one under test. -full_ir_checks
        # turns them back on for the base JIT, and -no_ir_checks turns them off everywhere.
        #
        # The diff artifact runs compare the base and diff JitDumps textually, so the checks

src/coreclr/jit/jitconfigvalues.h:199

• The comment for JitEnablePhaseChecks says "phase IR checks", but the gating in Phase::PostPhase controls all post-phase checks (flowgraph/EH/loops/profile/etc.). Consider tweaking the comment to reflect the broader scope.

CONFIG_INTEGER(JitEnablePhaseChecks, "JitEnablePhaseChecks", 1) // Run the phase IR checks

• Files reviewed: 4/4 changed files
• Comments generated: 1
• Review effort level: Lite