Repository navigation
[cDAC] Fix ARM64 save_any opcode decoding - #132187
Merged
Merged
Conversation
Co-authored-by: Copilot <[email protected]> Copilot-Session: 11b73ad8-c726-42c3-bc38-a8360c68b4de
rcj1
requested review from
max-charlamb and
noahfalk
and
a lite review from Copilot
and removed request for
Copilot
August 11, 2026 23:51
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
rcj1
enabled auto-merge (squash)
August 11, 2026 23:57
hoyosjs
approved these changes
Aug 12, 2026
max-charlamb
approved these changes
Aug 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects ARM64 unwind-code decoding for the save_any_* opcode in cDAC stack unwinding, ensuring the p/x/fixed bitfields are read from the correct byte, and adds a focused unit test to validate restoring a saved non-volatile register pair.
Changes:
- Fix
save_anybitfield extraction inARM64Unwinder.SaveAnyUnwindCodeto decodex,p, and the fixed-op bit from the0pxrrrrrbyte (not theffoooooobyte). - Add a unit test that constructs minimal ARM64
.pdata/.xdata+ stack memory to validatesave_anypair restore behavior forX19/X20.
Show a summary per file
| File | Description |
|---|---|
src/native/managed/cdac/tests/UnitTests/StackWalkTests.cs |
Adds a regression unit test covering ARM64 save_any pair unwind restoring saved registers from the stack. |
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/Context/ARM64/ARM64Unwinder.cs |
Fixes ARM64 save_any opcode decoding by extracting x/p/fixedOp from the correct encoding byte. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix decoding and add unit test.
https://learn.microsoft.com/en-us/cpp/build/arm64-exception-handling#unwind-codes