Repository navigation
[Wasm RyuJIT]: Remove more unreachable NYI_WASM entries - #132170
Merged
adamperlin merged 1 commit intoAug 12, 2026
Merged
Conversation
… common code between files/ifdefs
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes additional unreachable NYI_WASM paths in the JIT’s WASM target, tightens HAS_FIXED_REGISTER_SET conditionals around spill-related code, and centralizes CodeGenInterface::genUpdateVarReg into shared code.
Changes:
- Wrap spill handling (
genSpillVarand its call sites) in#if HAS_FIXED_REGISTER_SETto avoid WASM-only NYI stubs. - Replace
NYI_WASMfallbacks in WASMins_Load/ins_Storewithunreached(). - Move the multi-reg
CodeGenInterface::genUpdateVarRegimplementation intocodegencommon.cppand remove WASM NYI stubs.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/jit/treelifeupdater.cpp | Gates spill-triggered codegen callbacks behind HAS_FIXED_REGISTER_SET. |
| src/coreclr/jit/instr.cpp | Replaces WASM NYI fallbacks with unreached() and gates instGen_Set_Reg_To_Zero. |
| src/coreclr/jit/codegenwasm.cpp | Removes WASM NYI stubs for spill/update-var-reg and tightens overflow assumptions for float→int cast codegen. |
| src/coreclr/jit/codegenlinear.cpp | Switches spill support gating from !TARGET_WASM to HAS_FIXED_REGISTER_SET and removes moved genUpdateVarReg definition. |
| src/coreclr/jit/codegeninterface.h | Makes genSpillVar only part of the interface when HAS_FIXED_REGISTER_SET is true. |
| src/coreclr/jit/codegencommon.cpp | Adds shared implementation of multi-reg genUpdateVarReg. |
| src/coreclr/jit/codegen.h | Gates genSpillVar and fixed-register helpers behind HAS_FIXED_REGISTER_SET. |
Suppressed comments (1)
src/coreclr/jit/instr.cpp:2936
instGen_Set_Reg_To_Zerois now excluded whenHAS_FIXED_REGISTER_SETis 0 (e.g.TARGET_WASMdefines it as 0), but shared code (e.g.CodeGen::genGetZeroRegin codegencommon.cpp) still references it on WASM. That will lead to missing symbol/link or compile failures for WASM builds. Either keep a WASM implementation (even if it’s just local-set to zero) or ensure all callers are also under#if HAS_FIXED_REGISTER_SET.
#if HAS_FIXED_REGISTER_SET
/*****************************************************************************
*
* Machine independent way to move a Zero value into a register
*/
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
adamperlin
marked this pull request as ready for review
August 11, 2026 23:56
|
Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
AndyAyersMS
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also involves moving some
HAS_FIXED_REGISTER_SETifdefs around as well as moving the definition ofgenUpdateVarRegto codegencommon.