Repository navigation
Fix double slash when rejoining USTAR prefix and name - #131793
alinpahontu2912 merged 2 commits into
Conversation
Co-authored-by: alinpahontu2912 <[email protected]>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Fixes USTAR header name reconstruction so archives that (incorrectly) include a trailing / in the prefix field don’t produce a synthesized // when combining prefix + name.
Changes:
- Update
ReadUstarAttributesto conditionally insert the/separator only when_prefixdoesn’t already end with/.
|
Tagging subscribers to this area: @dotnet/area-system-formats-tar |
Co-authored-by: alinpahontu2912 <[email protected]>
|
@copilot address the remaining comment |
Addressed in Note AI/Copilot-generated response. |
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
/ba-g failures are unrelated |
ReadUstarAttributesunconditionally joined a non-empty ustarprefixandnamewith/, assuming the prefix never already ends with a separator. Archives with a trailing-slash prefix produced a synthesized//in the resulting logical path.Changes
TarHeader.Read.cs: check whether_prefixalready ends with/before inserting the separator when rejoiningprefixandname.