Repository navigation
Disable ReentrantWaitFromSyncContextTest test on Mono - #131548
Merged
Merged
Conversation
eduardo-vp
added
area-System.Threading
runtime-mono
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @VSadov |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the System.Threading Monitor test suite to avoid running ReentrantWaitFromSyncContextTest on Mono, where the runtime’s Monitor.Wait implementation doesn’t exercise the SynchronizationContext.Wait reentrancy scenario the test is intended to validate.
Changes:
- Replace the Mono-only
ActiveIssueskip with aConditionalFactguard that excludes Mono (PlatformDetection.IsNotMonoRuntime). - Add an explanatory comment documenting why the test is not applicable on Mono.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #126138. This was not an unexpected behavior on Mono, since Monitor.Wait is still implemented natively (CoreCLR moved to managed in .NET 11), it doesn't end up forwarding to
SynchronizationContext.Waitwhich is a necessary condition for this test.