Repository navigation
Initialize *ppv in comhost DllGetClassObject - #128916
Merged
Merged
Conversation
Co-authored-by: elinor-fung <[email protected]>
Copilot
AI
changed the title
[WIP] Fix DllGetClassObject to initialize out parameter
Initialize *ppv in comhost DllGetClassObject
Jun 2, 2026
elinor-fung
marked this pull request as ready for review
June 2, 2026 20:45
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the comhost COM entrypoint DllGetClassObject to ensure its ppv out-parameter is initialized on all exit paths, by validating ppv and setting *ppv = nullptr at function entry.
Changes:
- Add an early
ppv == nullptrguard returningE_POINTER. - Initialize
*ppvtonullptrbefore any failure-return paths are possible.
Show a summary per file
| File | Description |
|---|---|
| src/native/corehost/comhost/comhost.cpp | Ensures DllGetClassObject initializes the COM out parameter (*ppv) even when returning failure HRESULTs. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
AaronRobinsonMSFT
approved these changes
Jun 2, 2026
This was referenced Jun 3, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DllGetClassObjectinsrc/native/corehost/comhost/comhost.cpphad failure paths (CLSID not in map,get_com_delegatefailure) that returned a failure HRESULT without writing to*ppv, violating the COM contract that out parameters must always be initialized.Null it out on function entry.