Kill local asserts for partial write in copyBlock #1279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
added
the
area-CodeGen-coreclr
Contributor
Author
|
@dotnet/jit-contrib PTAL |
BruceForstall
approved these changes
Jan 6, 2020
briansull
approved these changes
Jan 6, 2020
Contributor
briansull
left a comment
briansull
left a comment
There was a problem hiding this comment.
Approved - With one comment to update
src/coreclr/src/jit/morph.cpp
Outdated
| #if LOCAL_ASSERTION_PROP | ||
| // Kill everything about destLclNum (and its field locals) | ||
| if (optLocalAssertionProp) | ||
| // Kill everything about destLclNum (and its field locals) |
Contributor
There was a problem hiding this comment.
destLclNum => modifiedLclNum
Contributor
Author
|
Merging without waiting for new CI round (last commit was comment-only) |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1241