Conversation
sbomer
added
the
NO-MERGE
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
There was a problem hiding this comment.
Pull request overview
This PR replaces container image references from the public Microsoft Container Registry (mcr.microsoft.com) to a private Azure Container Registry (svbomeracr.azurecr.io) for testing LLVM 22 toolchain changes in prerequisite Docker images (related to dotnet/dotnet-buildtools-prereqs-docker#1591). The PR title clearly indicates this is a "[testing]" change.
Changes:
- All
azurelinux-3.0-net11.0-*container images now reference the private svbomeracr.azurecr.io registry - Other container images (Ubuntu, Alpine, CentOS, Debian, etc.) continue to use the public MCR
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/pipelines/common/templates/pipeline-with-resources.yml | Updated 18 container image references for azurelinux-3.0-net11.0 variants to point to the private test registry |
| .github/workflows/jit-format.yml | Updated container reference for the JIT format workflow to use the private test registry |
| containers: | ||
| linux_arm: | ||
| image: mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-net11.0-cross-arm | ||
| image: svbomeracr.azurecr.io/dotnet-buildtools/prereqs:azurelinux-3.0-net11.0-cross-arm |
There was a problem hiding this comment.
This PR changes container image references from the public Microsoft Container Registry (mcr.microsoft.com) to a private Azure Container Registry (svbomeracr.azurecr.io) for testing purposes. This change should not be merged to the main branch as-is, as it would break builds for external contributors and the general public who do not have access to the private registry. Once testing is complete, these references should be reverted back to the public MCR, or the tested images should be published to MCR before merging.
| - name: linux | ||
| image: ubuntu-latest | ||
| container: mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-net11.0-cross-amd64 | ||
| container: svbomeracr.azurecr.io/dotnet-buildtools/prereqs:azurelinux-3.0-net11.0-cross-amd64 |
There was a problem hiding this comment.
The private container registry (svbomeracr.azurecr.io) reference should not be merged to the main branch. External contributors and public builds will not have access to this private registry, which would cause build failures. After testing is complete, revert to the public MCR reference.
| container: svbomeracr.azurecr.io/dotnet-buildtools/prereqs:azurelinux-3.0-net11.0-cross-amd64 | |
| container: mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-net11.0-cross-amd64 |
|
BA is green, all build issues are known. Opened dotnet/dotnet-buildtools-prereqs-docker#1597. |
Testing for dotnet/dotnet-buildtools-prereqs-docker#1591