[browser][CoreCLR] lazy and satelite assemblies#124853
Merged
pavelsavara merged 7 commits intodotnet:mainfrom Feb 26, 2026
Merged
[browser][CoreCLR] lazy and satelite assemblies#124853pavelsavara merged 7 commits intodotnet:mainfrom
pavelsavara merged 7 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @agocke, @jeffschwMSFT, @elinor-fung |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements support for loading satellite assemblies (localization resources) and lazy-loaded assemblies in the browser/CoreCLR JavaScript loader by wiring new loader export functions end-to-end (loader → cross-module table → interop INTERNAL.* APIs).
Changes:
- Implemented
loadSatelliteAssemblies/loadLazyAssemblyby delegating to loader-side asset fetchers. - Added new loader exports (
fetchSatelliteAssemblies,fetchLazyAssembly) to the cross-module exchange table and exposed them viadotnetLoaderExports. - Added support code for downloading/registration of satellite resources and lazy assemblies, plus PDB registration in the host FS.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/native/libs/System.Runtime.InteropServices.JavaScript.Native/interop/lazy.ts | Implements interop entrypoints by delegating to loader exports. |
| src/native/libs/Common/JavaScript/types/exchange.ts | Extends LoaderExports / LoaderExportsTable with new asset-fetching APIs. |
| src/native/libs/Common/JavaScript/loader/run.ts | Optionally preloads all satellite resources during startup. |
| src/native/libs/Common/JavaScript/loader/index.ts | Publishes the new loader functions into the cross-module table. |
| src/native/libs/Common/JavaScript/loader/config.ts | Updates resource merging to include satellite resource keys (but currently duplicates data). |
| src/native/libs/Common/JavaScript/loader/assets.ts | Adds fetchSatelliteAssemblies/fetchLazyAssembly and culture-aware assembly fetching. |
| src/native/libs/Common/JavaScript/host/assets.ts | Updates assembly name aliasing and implements PDB registration into the VFS. |
| src/native/libs/Common/JavaScript/cross-module/index.ts | Extends loader exports reconstruction from the exchange table. |
ilonatommy
reviewed
Feb 25, 2026
ilonatommy
reviewed
Feb 25, 2026
Member
ilonatommy
left a comment
ilonatommy
left a comment
There was a problem hiding this comment.
Apart from automated review (lazy loading / unexpected result of multiple calls of fetchDll) it loos good to me.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
ilonatommy
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #120226