Use ConditionalFact/ConditionalTheory ctor that passes type#124791
Open
akoeplinger wants to merge 4 commits intodotnet:mainfrom
Open
Use ConditionalFact/ConditionalTheory ctor that passes type#124791akoeplinger wants to merge 4 commits intodotnet:mainfrom
akoeplinger wants to merge 4 commits intodotnet:mainfrom
Conversation
Required for xunit v3 and the other ctor is marked obsolete as of https://github.com/dotnet/arcade
Member
Pan to me looking at PR with 306 files changed... |
Member
Author
lol yeah. not sure if @agocke missed something but at least this was a relatively painless edit with copilot. only the generic cases are a little painful (last commit)... |
Member
|
Yeah I was expecting ~50 changes, clearly my query missed something |
Member
|
I would look into an alternative but @akoeplinger has already done the work (thanks!). |
This was referenced Feb 24, 2026
Open
Member
Author
|
yeah it seems to work, not sure how/if you want to review it though :) |
Member
|
I’ll look through it tonight, I don’t mind reviewing mechanical prs |
agocke
approved these changes
Feb 25, 2026
This was hidden before because ConditionalFact just skipped the test in that case, but we now call this as part of the test itself in SmtpClientAuthTest.TestGssapiAuthentication(). Copy the try-catch from NegotiateAuthenticationPal.Unix.cs to fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for xunit v3 and the other ctor is marked obsolete as of dotnet/arcade#16537