Fix localization of ExtendedPropertyDescriptor.DisplayName#124771
Open
Zurisen wants to merge 1 commit intodotnet:mainfrom
Open
Fix localization of ExtendedPropertyDescriptor.DisplayName#124771Zurisen wants to merge 1 commit intodotnet:mainfrom
Zurisen wants to merge 1 commit intodotnet:mainfrom
Conversation
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-componentmodel |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a localization bug where the "on" text in extender property display names (e.g., "Error on errorProvider") was not being translated in non-English locales. The issue occurred because the code was bypassing localized resource strings in certain environments (trimmed/WASM) by using a hardcoded English fallback string.
Changes:
- Removed an unnecessary ternary expression that was checking
SR.UsingResourceKeys()and providing a hardcoded English fallback string"{0} on {1}"instead of using the localizableSR.MetaExtenderNameresource.
Author
|
The failing System.Net.Http.Functional.Tests work item appears to be unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108422
Summary
ExtendedPropertyDescriptor.DisplayNamewas using a ternary that fell back to the hardcoded English string"{0} on {1}"whenSR.UsingResourceKeys()returnedtrue(e.g. in trimmed or WASM environments), bypassing the already-localizedSR.MetaExtenderNameresource.Change
Removed the unnecessary ternary.
SR.Format(SR.MetaExtenderName, ...)already handles all environments correctly and uses the localized string as intended.Testing
System.ComponentModel.TypeConverterpass.