renames to IsMultithreadingSupported#124653
Merged
pavelsavara merged 8 commits intodotnet:mainfrom Feb 20, 2026
Merged
Conversation
…ultithreadingSupported
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs a comprehensive rename to prepare for API changes in PR #124603. The changes rename internal and test-related properties/methods from "Threading" to "Multithreading" and from "SingleThreaded" to "MultithreadingSupported" (with inverted logic).
Changes:
- Renamed
PlatformDetection.IsThreadingSupported→IsMultithreadingSupportedandIsThreadingNotSupported→IsNotMultithreadingSupportedacross all test files - Renamed internal
Thread.IsSingleThreaded→Thread.IsMultithreadingSupportedandThread.ThrowIfSingleThreaded()→Thread.ThrowIfMultithreadingIsNotSupported()with proper logic inversions - Updated documentation and comments to reflect new terminology
Reviewed changes
Copilot reviewed 280 out of 281 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/Common/CoreCLRTestLibrary/PlatformDetection.cs | Renamed test utility properties for multithreading detection |
| src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs | Renamed test utility properties for multithreading detection |
| src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs | Updated SpinWait to check IsMultithreadingSupported instead of IsSingleThreaded with inverted logic |
| src/libraries/System.Threading.Tasks.Parallel/src/System/Threading/Tasks/Parallel.cs | Renamed IsSingleThreaded → IsMultithreadingSupported with proper logic inversion |
| src/libraries/System.Threading.Tasks.Parallel/src/System/Threading/Tasks/TaskReplicator.cs | Updated condition to use !IsMultithreadingSupported instead of IsSingleThreaded |
| src/libraries/System.Private.CoreLib/src/System/Threading/*.cs | Updated threading infrastructure to use new naming with proper logic inversions |
| src/libraries/System.Private.CoreLib/src/System/IO/*.cs | Updated Stream and TextWriter to use new naming with proper logic inversions |
| src/mono/wasm/threads.md | Updated documentation to reference new API names |
| src/mono/System.Private.CoreLib/src/System/Threading/Monitor.Mono.cs | Updated method call to ThrowIfMultithreadingIsNotSupported() |
| eng/testing/tests.browser.targets | Updated comment to reference IsMultithreadingSupported |
| 200+ test files | Updated ConditionalFact/ConditionalTheory/ConditionalClass attributes and ActiveIssue comments |
Contributor
|
Tagging subscribers to this area: @agocke, @VSadov |
jkotas
approved these changes
Feb 20, 2026
Member
Author
|
/ba-g untelated OOM and known issues |
This was referenced Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boring prep for #124603