Publish AOT managed-ilasm and include in Core_Root#124600
Publish AOT managed-ilasm and include in Core_Root#124600jkoritzinsky merged 2 commits intodotnet:mainfrom
Conversation
f277a9e to
52aae2e
Compare
|
Tagging subscribers to this area: @JulieLeeMSFT, @dotnet/jit-contrib |
7092db3 to
5c45544
Compare
b4e12fd to
9777c82
Compare
|
@am11 @jkoritzinsky this causes a few prebuilts in dotnet/dotnet#5026 |
|
tunnelvisionlabs/antlr4cs#364 was never released. Long term: we can request @sharwell and co. to publish a release, or fork that repo under Short term: add those prebuilds or conditionally disable managed ilasm for
|
tunnelvisionlabs/antlr4cs#381 (comment) suggests the path forward is https://github.com/antlr/antlr4 and https://www.nuget.org/packages/Antlr4.Runtime.Standard#dependencies-body-tab, which looks more "official". @jkoritzinsky, shall we migrate to it? At least, it will eliminate |
|
First off I'm a bit confused why nuget package pruning didn't get rid of the Microsoft.NETCore.Platforms/NETStandard.Library. For the managed-ilasm: as far as I understand it's only used in tests so far and not planned to be shipped in the dotnet sdk for some time right? In that case I'd prefer to disable building it in the VMR completely, not just source-build |
|
The last update to that Antlr package on nuget.org was in 2018, so I guess NetStandard 1x are not pruned? Packages targeting NetStandard 2x are pretty common.
Yes, in short term, we don't need it. Once we are able to run round-trip tests with it, we can then just swap the binary in existing ilasm nuget pacakge with this new one. At that point we will need it. Basically code is completed + all the TODOs resolved. The next step is to run tests and fine-tune. (I am waiting for #124661 to be resolved first..) |
Ok looks like all the dependencies of NETStandard.Library 1.6.0 are pruned but not the meta-package itself. Not sure if this is intentional.
Let's cross that bridge when we get there then :) |
|
@am11 I agree, we should migrate to the new Antlr4.Runtime.Standard package. In the meantime, we should disable building managed ilasm when building from source or in the VMR completely (I can hook up the rest of the infra across the stack to support it and then we can turn it back on). |

Haven't used it in round-trip test yet.