Mono: increase default stack size on s390x/ppc64le; support DOTNET_Thread_DefaultStackSize for setting stack size.#124588
Conversation
|
Per my comments in #124368, I also want to take a closer look at the Alpine/Musl (under My main interest is to have this change so that the F# compiler doesn't run out of stack space while compiling fsharp repo during the .NET build on ppc64le and s390x (dotnet/fsharp#19286). |
|
Should we consider just using |
I am hesitant to bump the default stack sizes further. This was discussed before in #98007 |
… config through DOTNET_Thread_DefaultStackSize envvar.
fe0e2f5 to
0dd5dcd
Compare
|
@jkotas @akoeplinger I've made changed based on your feedback. Please take another look. |
akoeplinger
left a comment
There was a problem hiding this comment.
LGTM with small comments. please fix the PR description/title
Co-authored-by: Alexander Köplinger <[email protected]>
|
I've updated the title/description. Thanks for reviewing and feedback @akoeplinger and @jkotas! |
This increases the default stack size on s390x and ppc64le. Due to missing implementation for tail call optimization, the vmr build exhaust the stack while building the fsharp repo. With an 8MB stack, the build can complete.
Additionally this adds support for a user to control the stack size using the DOTNET_Thread_DefaultStackSize envvar.
Fixes #124368.
@jkotas @akoeplinger @hamarb123 ptal.