ArrayBufferWriter double grow boundary fix#124470
Merged
jkotas merged 1 commit intodotnet:mainfrom Feb 16, 2026
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-buffers |
jkotas
approved these changes
Feb 16, 2026
Member
|
/ba-g infra timeout |
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArrayBufferWriter unexpectedly fails to reallocate if current length is int.MaxValue/2, e.g.:
var abw = new ArrayBufferWriter(int.MaxValue / 2);
abw.Advance(abw.Capacity);
abw.GetMemory(1); // throws
Unfortunately it's hard to write a test because the result will be OutOfMemoryException, same as if there is just not enough memory.
Found by Linux Verification Center (linuxtesting.org).