Add more null checks to request.cpp#124451
Merged
leculver merged 3 commits intodotnet:mainfrom Feb 18, 2026
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens CoreCLR’s SOS DAC request handling to avoid Linux SIGSEGVs when older diagnostic tools call into the DAC with null/zero arguments, returning explicit HRESULTs instead of crashing.
Changes:
- Added argument validation to reject zero CLRDATA_ADDRESS inputs in several DAC entrypoints.
- Added broader parameter validation for
GetAssemblyNameto avoid invalid buffer/size combinations. - Tightened
GetAssemblyDatavalidation to reject a nullassemblyaddress.
This was referenced Feb 16, 2026
noahfalk
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm seeing crashes on linux in diagnostic tools (clrmd, sos, dotnet-dump analyze). These come from tools not validating their calls into the dac. I'm fixing this in those tools, but older versions of those tools will call with null values in some cases. This fix will simply stop us from crashing with a SIGSEGV on linux since we do not swallow crashes on that OS.
Contributes to: dotnet/diagnostics#5632.