src/coreclr/scripts/superpmi_aspnet2.py:303

• The kill_port(CRANK_PORT) is called before argument parsing, which means it will attempt to kill processes on the port even if the script is invoked with invalid arguments or just --help. This could have unintended side effects. Consider moving this call after argument parsing and validation to ensure it only runs when the script will actually proceed with execution.

        cmd.extend([

src/coreclr/scripts/superpmi_aspnet2.py:351

• Using shutil.rmtree without ignore_errors=True or onerror parameter could fail if files are locked or permissions are insufficient, causing the script to crash. Consider adding error handling here or using shutil.rmtree(work_dir_base, ignore_errors=True) to ensure the script can continue even if cleanup fails. This is especially important on Windows where file locks are more common.

            sys.exit(2)

    # Create or use working directory for crank_data
    if args.work_dir:

src/coreclr/scripts/superpmi_aspnet2.py:385

• The removal of the {"TieredPGO": "1", "ReadyToRun": "0"} configuration means SPMI data will no longer be collected with Tiered PGO enabled. This could result in missing important JIT code patterns that only occur with PGO. Verify this removal is intentional and won't negatively impact the completeness of the SPMI collection.

            ("NoMvcAuth",

src/coreclr/scripts/superpmi_aspnet2.py:273

• The removal of --load.variables.duration and --load.variables.warmup settings means these will now use crank's defaults. Without explicit duration and warmup settings, the benchmark runs may be too short or too long, potentially affecting the quality of SPMI collection. Consider whether explicit values should be retained to ensure consistent collection behavior across runs.

    coreclr = native_dll("coreclr")
    spcorelib = "System.Private.CoreLib.dll"
    cmd = [
        str(crank_app),
        "--config", "https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/azure.profile.yml",

src/coreclr/scripts/superpmi_aspnet2.py:385

• The comment "Baseline with no environment variables set" is misleading because the "Dummy" variable IS being set to "0". If the intention is to have a baseline with no custom DOTNET_ environment variables, the empty dictionary {} should be used instead. If "Dummy" serves a specific purpose, the comment should explain why it's needed rather than claiming no variables are set.

            ("NoMvcAuth",

src/coreclr/scripts/superpmi_aspnet2.py:270

• The removal of pinned ASP.NET Core and runtime versions means the benchmarks will now use whatever versions match the specified framework. While the original TODO comment indicated this unpinning was desired, this change could lead to non-deterministic SPMI collection if different Helix machines have different versions available. Consider whether explicit version pinning should be retained for reproducibility, or if the build system ensures consistent versions across all collection machines.

    coreclr = native_dll("coreclr")
    spcorelib = "System.Private.CoreLib.dll"