Add exception catching comment to code review skill#124201
Merged
stephentoub merged 1 commit intodotnet:mainfrom Feb 9, 2026
Merged
Add exception catching comment to code review skill#124201stephentoub merged 1 commit intodotnet:mainfrom
stephentoub merged 1 commit intodotnet:mainfrom
Conversation
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the code review skill guidance to explicitly encourage reviewers to question newly introduced try/catch blocks that silently discard exceptions, aligning reviews toward surfacing unexpected failures instead of masking them.
Changes:
- Adds a new guideline emphasizing skepticism of exception swallowing that could hide unexpected/root-cause failures.
- Includes an illustrative quote supporting a “fail fast / don’t mask malformed input” strategy.
jkotas
added
area-skills
Member
Author
|
/ba-g markdown only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.