[release/10.0] Fix EH profiler notifications#124174
Merged
akoeplinger merged 4 commits intorelease/10.0from Feb 10, 2026
Merged
[release/10.0] Fix EH profiler notifications#124174akoeplinger merged 4 commits intorelease/10.0from
akoeplinger merged 4 commits intorelease/10.0from
Conversation
The new EH was incorrectly notifying exception search and unwind function enter / leave in case of funclets. For each funclet, it was reporting enter and leave of the parent and then it reported it again for the parent itself. This was different from the old EH behavior where only one enter / leave was reported for each method. This change rectifies it. Close #123351
jkotas
approved these changes
Feb 9, 2026
This was referenced Feb 9, 2026
Member
|
@janvorli the failures do not appear to be related, but I restarted the failing jobs just in case. Give it one more pass and then I think it can be merged. |
noahfalk
approved these changes
Feb 10, 2026
Member
|
/ba-g Unrelated mono failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #123564 to release/10.0
/cc @janvorli
Customer Impact
The new exception handling incorrectly calls callbacks
ExceptionSearchFunctionEnter/LeaveandExceptionUnwindFunctionEnter/Leavefor funclets (catch / finally blocks) in a method. That results in those callbacks being called multiple times for the same method instead of just once. The number of extra calls depend on how many funclets are embedded in other funclets. Below is an example that will call those callback 3 times reporting theFoo. Once per each finally and then once per the actual method.Depending on the profiler implementation, it can possibly lead to crash or misbehavior of the profiler
Regression
The regression was introduced in .NET 9 when the new EH was enabled by default.
Testing
The fix was verified using a repro code provided by the customer that reported the issue.
Risk
Low, the change just prevents the callbacks in funclets and makes it equivalent to the behavior before the new EH.