Rename azdo-helix-failures to ci-analysis and improve SKILL.md#124151
Merged
Rename azdo-helix-failures to ci-analysis and improve SKILL.md#124151
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Documentation-only update improving the .github/skills/azdo-helix-failures skill guide to better steer users toward the right analysis mode (PR vs Build ID vs Helix job) and to add decision-point warnings/anti-patterns for interpreting AzDO/Helix results.
Changes:
- Expanded trigger phrases and added a “When NOT to Use” section to reduce misuse (e.g., GitHub Actions vs AzDO/Helix).
- Added a “Three Modes” decision table and reorganized “What the Script Does” by mode.
- Added inline warnings about canceled jobs, infra-vs-code classification, flow PR missing-package scenarios, and heuristic retry guidance.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
.github/skills/ci-analysis/scripts/Get-CIStatus.ps1:1
- The file now starts with a UTF-8 BOM character (shown as an invisible char before
<#). Other PowerShell scripts in this repo (e.g.,.github/skills/vmr-codeflow-status/scripts/Get-CodeflowStatus.ps1) start directly with<#without a BOM. Please remove the BOM to avoid odd diffs/tooling issues when running or parsing the script cross-platform.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
.github/skills/ci-analysis/scripts/Get-CIStatus.ps1:8
- The script has been renamed/broadened to CI status analysis, but the
.SYNOPSISstill says it only “Retrieves test failures…”. Please update the synopsis/description so it matches the current scope (build status + failures + Helix job/work item queries).
.github/skills/ci-analysis/scripts/Get-CIStatus.ps1:165 -ClearCacheonly removes the newci-analysis-cachedirectory. Since this is a rename fromhelix-failures-cache, users may end up with orphaned old cache data that never gets cleaned up. Consider clearing both directories (old + new) for backwards compatibility, or at least printing where the previous cache lived so users can remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames and improves the CI analysis skill (formerly
azdo-helix-failures).Rename:
azdo-helix-failures→ci-analysisGet-HelixFailures.ps1→Get-CIStatus.ps1azdo-helix-failures→ci-analysisSKILL.md improvements (skill-builder patterns):
--approve/--request-changes), no branch switching (git checkout/gh pr checkout)-WorkItemoptionalgh pr checkstip — Valid--jsonfields documented (noconclusion— usestate)Script fixes:
helix-failures-cachetoci-analysis-cachecc @dotnet/runtime-infrastructure