Conversation
github-actions
bot
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
the
linkable-framework
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/illink |
sbomer
approved these changes
Feb 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes malformed/invalid XML documentation comments in ILLink trim analysis sources so builds that emit XML docs don’t fail.
Changes:
- Replace
Nullable<T>text in XML docs withNullable{T}to avoid invalid XML tags in doc output. - Wrap
<item>entries in<list>blocks where needed inIntrinsicIdenum member summaries. - Fix a malformed
<see cref="...">entry and complete a missing<summary>block.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/tools/illink/src/ILLink.Shared/TrimAnalysis/RuntimeTypeHandleForNullableValueWithDynamicallyAccessedMembers.cs | Escapes Nullable<T> text in XML docs to valid Nullable{T}. |
| src/tools/illink/src/ILLink.Shared/TrimAnalysis/RuntimeTypeHandleForNullableSystemTypeValue.cs | Escapes Nullable<T> text in XML docs to valid Nullable{T}. |
| src/tools/illink/src/ILLink.Shared/TrimAnalysis/NullableValueWithDynamicallyAccessedMembers.cs | Escapes Nullable<T> text in XML docs to valid Nullable{T}. |
| src/tools/illink/src/ILLink.Shared/TrimAnalysis/NullableSystemTypeValue.cs | Escapes Nullable<T> text in XML docs to valid Nullable{T}. |
| src/tools/illink/src/ILLink.Shared/TrimAnalysis/IntrinsicId.cs | Makes enum XML docs well-formed by adding <list> wrappers, fixing a malformed cref, and closing a missing <summary>. |
src/tools/illink/src/ILLink.Shared/TrimAnalysis/RuntimeTypeHandleForNullableSystemTypeValue.cs
Show resolved
Hide resolved
lewing
pushed a commit
to lewing/runtime
that referenced
this pull request
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to build an assembly with XML docs and the build failed on these ILink docs.