Delete GetFriendlyErrorCodeString and HAVE_STRERRORNAME_NP#124090
Merged
Delete GetFriendlyErrorCodeString and HAVE_STRERRORNAME_NP#124090
Conversation
Co-authored-by: jkotas <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes PAL dead code related to generating “friendly” errno names and removes the associated (unused) CMake feature detection for strerrorname_np.
Changes:
- Deleted
GetFriendlyErrorCodeStringdeclaration and implementation from PAL utilities. - Removed
HAVE_STRERRORNAME_NPdetection from PAL CMake configuration. - Removed
HAVE_STRERRORNAME_NPfrom the browser tryrun cache.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/pal/src/misc/utils.cpp | Removes GetFriendlyErrorCodeString implementation. |
| src/coreclr/pal/src/include/pal/utils.h | Removes GetFriendlyErrorCodeString declaration. |
| src/coreclr/pal/src/configure.cmake | Removes strerrorname_np feature check / HAVE_STRERRORNAME_NP definition. |
| eng/native/tryrun.browser.cmake | Removes cached HAVE_STRERRORNAME_NP entry for browser tryrun. |
Copilot
AI
changed the title
[WIP] Remove GetFriendlyErrorCodeString and HAVE_STRERRORNAME_NP dead code
Delete GetFriendlyErrorCodeString and HAVE_STRERRORNAME_NP
Feb 6, 2026
AaronRobinsonMSFT
approved these changes
Feb 6, 2026
stephentoub
approved these changes
Feb 6, 2026
jkoritzinsky
approved these changes
Feb 6, 2026
Member
|
/ba-g infrastructure timeouts |
AaronRobinsonMSFT
deleted the
copilot/remove-getfriendlyerrorcodeststring
branch
lewing
pushed a commit
to lewing/runtime
that referenced
this pull request
Feb 9, 2026
…4090) Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: jkotas <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes unused
GetFriendlyErrorCodeStringfunction and its associatedHAVE_STRERRORNAME_NPCMake configuration. No callsites exist in the codebase.Changes
GetFriendlyErrorCodeStringdeclaration and 57-line implementation from PAL utilsHAVE_STRERRORNAME_NPCMake check and browser tryrun cache entryFiles Modified
src/coreclr/pal/src/include/pal/utils.hsrc/coreclr/pal/src/misc/utils.cppsrc/coreclr/pal/src/configure.cmakeeng/native/tryrun.browser.cmakeOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.