Fix removing module from appdomain in DB_IPCE_UNLOAD_MODULE event#123931
Merged
hoyosjs merged 1 commit intodotnet:mainfrom Feb 10, 2026
Merged
Fix removing module from appdomain in DB_IPCE_UNLOAD_MODULE event#123931hoyosjs merged 1 commit intodotnet:mainfrom
hoyosjs merged 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
This was referenced Feb 3, 2026
thaystg
approved these changes
Feb 4, 2026
hoyosjs
approved these changes
Feb 5, 2026
elinor-fung
approved these changes
Feb 6, 2026
Member
|
/ba-g failure is #123912 |
1 similar comment
Member
|
/ba-g failure is #123912 |
Member
|
/backport to release/10.0 |
Contributor
|
Started backporting to |
4 tasks
steveisok
pushed a commit
that referenced
this pull request
Feb 11, 2026
…ODULE event (#124241) Backport of #123931 to release/10.0 /cc @hoyosjs @tommcdon ## Customer Impact - [X] Customer reported - [ ] Found internally When loading and unloading an Assembly multiple times in new AssemblyLoadContexts Visual Studio will abruptly end debugging before program completion with the following error: > A fatal error has occurred and debugging needs to be terminated. For more details, please see the Microsoft Help and Support web site. HRESULT=0x80131c36. ErrorCode=0x0. Originally reported via Visual Studio feedback item [Fatal error encountered when debugging .net 10 app using collectible assemblies in VS2026](https://developercommunity.visualstudio.com/t/Fatal-error-encountered-when-debugging-/10982926), then moved to GH issue #123930. ## Regression - [X] Yes - [ ] No Regression from .NET 9, introduced in .NET 10 on #117224 and was a missed case when attempting to address the issue in #118414. ## Testing Validated with customer's reproducible test case on #123930 ## Risk Low. The debugger module caches uses the module as the hash key rather than the assembly. This was a missed case when fixing #118414 where we were still incorrectly using the assembly as the lookup key. Co-authored-by: Tom McDonald <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The debugger keeps track of loaded modules in a hashtable. When a module is unloaded, it should be removed from the hash, otherwise it will incorrectly cache the module on subsequent re-loads.
Fixes #123930