Stackalloc cert handles in SafeDeleteSslContext.SetCertificate on macOS#123905
Merged
stephentoub merged 2 commits intodotnet:mainfrom Feb 3, 2026
Merged
Stackalloc cert handles in SafeDeleteSslContext.SetCertificate on macOS#123905stephentoub merged 2 commits intodotnet:mainfrom
stephentoub merged 2 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
bartonjs
approved these changes
Feb 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Optimizes macOS TLS certificate chain setup by attempting to avoid heap allocations when building the certificate handle list for SSLSetCertificate.
Changes:
- Introduces a stackalloc/heap fallback strategy for the certificate handle buffer in
SafeDeleteSslContext.SetCertificate. - Adds a local threshold constant to control when stack allocation is used.
src/libraries/System.Net.Security/src/System/Net/Security/Pal.OSX/SafeDeleteSslContext.cs
Show resolved
Hide resolved
src/libraries/System.Net.Security/src/System/Net/Security/Pal.OSX/SafeDeleteSslContext.cs
Show resolved
Hide resolved
bartonjs
approved these changes
Feb 2, 2026
This was referenced Feb 3, 2026
Open
Member
Author
|
/ba-g timeouts |
lewing
pushed a commit
to lewing/runtime
that referenced
this pull request
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.