Avoid array allocations in GetRequestCertificateAuthorities#123904
Merged
stephentoub merged 1 commit intodotnet:mainfrom Feb 3, 2026
Merged
Avoid array allocations in GetRequestCertificateAuthorities#123904stephentoub merged 1 commit intodotnet:mainfrom
stephentoub merged 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the GetRequestCertificateAuthorities method on Windows and macOS platforms by eliminating unnecessary array allocations when processing certificate authority distinguished names.
Changes:
- Replaced array allocation with direct
ReadOnlySpan<byte>usage on both platforms - On macOS, replaced
CFGetData()withCFDataDangerousGetSpan()using proper reference counting
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Net.Security/src/System/Net/CertificateValidationPal.Windows.cs | Changed from ToArray() to direct ReadOnlySpan<byte> usage to avoid array allocation |
| src/libraries/System.Net.Security/src/System/Net/CertificateValidationPal.OSX.cs | Replaced CFGetData() with CFDataDangerousGetSpan() and manual reference counting to avoid array allocation |
bartonjs
approved these changes
Feb 2, 2026
This was referenced Feb 3, 2026
Member
Author
|
/ba-g timeouts |
lewing
pushed a commit
to lewing/runtime
that referenced
this pull request
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.