Avoid unnecessary DirectoryInfo allocation in FileInfo.MoveTo#123893
Merged
stephentoub merged 1 commit intodotnet:mainfrom Feb 2, 2026
Merged
Avoid unnecessary DirectoryInfo allocation in FileInfo.MoveTo#123893stephentoub merged 1 commit intodotnet:mainfrom
stephentoub merged 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-io |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the FileInfo.MoveTo method by replacing an unnecessary DirectoryInfo allocation with a direct call to Directory.Exists, improving performance while maintaining equivalent functionality.
Changes:
- Replaced
new DirectoryInfo(Path.GetDirectoryName(FullName)!).ExistswithDirectory.Exists(Path.GetDirectoryName(FullName))to avoid allocating a DirectoryInfo object - Removed the null-forgiving operator (
!) as Directory.Exists properly handles null input
jkotas
approved these changes
Feb 2, 2026
lewing
pushed a commit
to lewing/runtime
that referenced
this pull request
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.