Lazy-initialize DateTimeFormatInfoScanner.m_dateWords#123886
Merged
stephentoub merged 1 commit intodotnet:mainfrom Feb 2, 2026
Merged
Lazy-initialize DateTimeFormatInfoScanner.m_dateWords#123886stephentoub merged 1 commit intodotnet:mainfrom
stephentoub merged 1 commit intodotnet:mainfrom
Conversation
All the checks were already in place to lazy-initialize, and only a subset of cultures have date words.
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates DateTimeFormatInfoScanner to lazily initialize its internal date word collection, avoiding unnecessary allocations for cultures that have no date words, and cleans up documentation and implementation details.
Changes:
- Remove the legacy banner comment and replace it with an XML
<summary>comment describingDateTimeFormatInfoScannerand its role inDateTime.Parse. - Change
m_dateWordsfrom an eagerly initializedList<string>to a nullableList<string>?that is lazily initialized where needed, using collection expressions (m_dateWords ??= []). - Simplify
GetDateWordsOfDTFIby using pattern matching onm_dateWordsandList.ToArray()instead of manual array allocation and copying, and fix a spelling mistake in a comment (“Enumarate” → “Enumerate”).
MihaZupan
approved these changes
Feb 2, 2026
tarekgh
approved these changes
Feb 2, 2026
This was referenced Feb 2, 2026
lewing
pushed a commit
to lewing/runtime
that referenced
this pull request
Feb 9, 2026
All the checks were already in place to lazy-initialize, and only a subset of cultures have date words.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the checks were already in place to lazy-initialize, and only a subset of cultures have date words.