[Wasm RyuJIT] Add missing TYP_REF check#123019
Merged
kg merged 1 commit intodotnet:mainfrom Jan 9, 2026
Merged
Conversation
kg
added
arch-wasm
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a missing type check in the WebAssembly JIT code generator. The PackOperAndType function was only normalizing TYP_BYREF (managed pointer) types to TYP_I_IMPL (native integer type), but it should also normalize TYP_REF (object reference) types the same way. This fix resolves over 100 superPMI failures.
Key Changes
- Added
TYP_REFcheck alongside existingTYP_BYREFcheck in thePackOperAndTypefunction
AndyAyersMS
approved these changes
Jan 9, 2026
Member
Author
|
/ba-g known unrelated lane flakes |
This was referenced Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bit over a hundred superPMI failures.
Should we centralize this somewhere else? This feels like it's probably a decent place for it.