[clr-interp] Fix EmptyThisCall test#122936
Merged
davidwrighton merged 2 commits intodotnet:mainfrom Jan 7, 2026
Merged
Conversation
Member
davidwrighton
commented
Jan 6, 2026
davidwrighton
commented
- Add detection for attempting to call function with this call calling convention without actually passing a this argument.
- Add detection for attempting to call function with this call calling convention without actually passing a this argument.
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds validation to detect an invalid scenario in the CoreCLR interpreter where a function using an instance method calling convention (such as thiscall, CMemberFunction, etc.) is called with zero arguments. Instance method calling conventions require at least one argument (the 'this' pointer), so calling such a function with zero arguments is invalid code.
Key changes:
- New validation function
CheckForPInvokeThisCallWithNoArgsdetects the invalid scenario - Check is applied to both calli instructions and regular PInvoke calls
- Error message matches the existing check in the JIT compiler
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/interpreter/compiler.h | Adds declaration for the new validation function |
| src/coreclr/interpreter/compiler.cpp | Implements the validation function and adds calls at two locations: for calli instructions and for direct PInvoke calls |
This was referenced Jan 7, 2026
Open
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.