Merged
Conversation
Contributor
|
Tagging subscribers to this area: @thaystg, @dotnet/dotnet-diag |
thaystg
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue with debugging jagged arrays (specifically string[][]) when using the ICorDebug protocol. The fix adds support for properly returning type information for single-dimensional arrays (SZARRAY) containing arrays as elements.
Key changes:
- Increments the debugger protocol minor version from 66 to 67 to track this enhancement
- Adds logic to return element class type information for SZARRAY types when using ICorDebug with protocol version 2.67+
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/mono/mono/component/debugger-protocol.h | Bumps protocol minor version to 67 to track the new SZARRAY handling capability |
| src/mono/mono/component/debugger-agent.c | Adds conditional logic to buffer element class type ID for SZARRAY types when using ICorDebug |
steveisok
approved these changes
Jan 6, 2026
This was referenced Jan 6, 2026
Member
Author
|
/ba-g known failures. |
Member
Author
|
/backport to release/10.0 |
Contributor
|
Started backporting to |
4 tasks
This was referenced Jan 9, 2026
steveisok
pushed a commit
that referenced
this pull request
Jan 29, 2026
Backport of #122935 to release/10.0 /cc @thaystg ## Customer Impact - [X] Customer reported - [X] Found internally This fix resolves an issue when debugging on mobile or wasm where incorrect type parameters are returned while inspecting a multidimensional array. See also https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2633466 ## Regression - [ ] Yes - [X] No ## Testing Manually ran through VS before and after ## Risk Low **IMPORTANT**: If this backport is for a servicing release, please verify that: - For .NET 8 and .NET 9: The PR target branch is `release/X.0-staging`, not `release/X.0`. - For .NET 10+: The PR target branch is `release/X.0` (no `-staging` suffix). ## Package authoring no longer needed in .NET 9 **IMPORTANT**: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version. Keep in mind that we still need package authoring in .NET 8 and older versions. Co-authored-by: Thays Grazia <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix inspect obj.TestProperty