Remove PlatformDetection.IsWindows7 and IsNotWindows7 properties by Copilot · Pull Request #122907 · dotnet/runtime

Copilot · 2026-01-05T23:59:56Z

Description

Removes PlatformDetection.IsWindows7 and PlatformDetection.IsNotWindows7 properties throughout the codebase. Since Windows 7 is no longer supported, these properties always evaluate to false and true respectively.

Key changes:

Removed property definitions from PlatformDetection.Windows.cs and PlatformDetection.cs
Simplified TLS support detection (GetTls11Support, GetTls12Support) by removing Windows 7 special cases
Removed Windows 7 buffer size workaround in ConsolePal.Windows.cs
Updated util_nodependencies.cpp to make Windows 8 the minimum supported platform
Removed unnecessary #include <versionhelpers.h> from util_nodependencies.cpp
Deleted entire OS version detection infrastructure:
- Removed RunningOnStatusEnum enum definition
- Removed gRunningOnStatus global variable
- Removed InitRunningOnVersionStatus() function
- Removed RunningOnWin8() function (assumed to always return TRUE)
- Removed WinRTSupported() function (assumed to always return TRUE)
- Deleted ostype.h file entirely and moved RunningInWow64() to utilcode.h
Deleted obsolete Windows 7-related helper properties and methods:
- GetGdiPlusIsAvailableNotWindows7 (replaced with GetIsDrawingSupported)
- IsWindows8xOrLater (replaced with IsWindows)
- IsNotWindows7AndIsWindowsImplementation (replaced with Helpers.IsWindowsImplementation)
- IsWindows8OrLater (replaced with PlatformDetection.IsWindows)
- SupportsIdna property (deleted entirely - always true)
Deleted Windows 7-specific test data files (entire Unicode_Win7 directory including IdnaTest_Win7.txt and Unicode_Win7_IdnaTest.cs)
Removed references to Windows 7 test data from project files (System.Globalization.Extensions.Tests.csproj and System.Globalization.Extensions.Nls.Tests.csproj)
Converted ConditionalTheory/Fact(IsNotWindows7) to regular Theory/Fact attributes
Fixed all ConditionalTheory/ConditionalFact patterns to use typeof(Helpers), nameof(Helpers.IsWindowsImplementation) or typeof(PlatformDetection), nameof(PlatformDetection.IsWindows) as appropriate
Removed early returns and dead code blocks checking IsWindows7, SupportsIdna, or WinRTSupported
Removed Windows 7-specific comments and assertions
Simplified ServerCertCallback switch statement in SslStreamSystemDefaultsTest.cs by removing redundant case for SslPolicyErrors.RemoteCertificateNotAvailable that matched the default behavior

Customer Impact

None. Windows 7 support was already dropped. This is code cleanup.

Regression

No. This change removes detection for an unsupported platform.

Testing

Existing tests continue to pass. Tests that previously ran conditionally on Windows 8+ now run unconditionally on all Windows versions.

Risk

Low. Changes are purely simplifications based on the invariant that Windows 7 is not supported. No functional behavior changes for supported platforms.

Original prompt

Create PR that deletes PlatformDetection.IsWindows7 and PlatformDetection.IsNotWindows7 properties. We do not support Windows 7 anymore so we can assume IsWindows7=false and IsNotWindows7=true .

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

- Remove IsWindows7 and IsNotWindows7 property definitions from PlatformDetection.Windows.cs - Simplify conditional logic that checked IsWindows7 (always false) or IsNotWindows7 (always true) - Update GetAlpnSupport, GetTls11Support, GetTls12Support, GetSendsCAListByDefault in PlatformDetection.cs - Remove IsInAppContainer Windows 7 check - Convert ConditionalTheory/ConditionalFact attributes to regular Theory/Fact where they only checked IsNotWindows7 - Remove early returns in tests that checked IsWindows7 - Simplify ternary expressions that used IsWindows7 - Remove helper properties that depended on IsWindows7 - Remove IsWindows7() method from ConsolePal.Windows.cs - Remove IsWindows7 property from test library Utilities.cs - Update util_nodependencies.cpp to make Windows 8 the minimum supported version Co-authored-by: jkotas <[email protected]>

Co-authored-by: jkotas <[email protected]>

…onditionals Co-authored-by: jkotas <[email protected]>

Co-authored-by: jkotas <[email protected]>

src/coreclr/utilcode/util_nodependencies.cpp

src/libraries/Common/tests/System/Drawing/Helpers.cs

src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/PlatformHandlerTest.cs

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs

src/libraries/System.Net.HttpListener/tests/HttpListenerWebSocketTests.cs

src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamSystemDefaultsTest.cs

...raries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs

src/tests/Interop/IJW/NativeCallingManaged/NativeCallingManaged.cs

src/tests/Interop/IJW/ManagedCallingNative/ManagedCallingNative.cs

- Delete RUNNING_ON_WIN7 from RunningOnStatusEnum - Update RUNNING_ON_WIN8 value from 2 to 1 - Update comment to reflect Win8 as minimum supported platform Co-authored-by: jkotas <[email protected]>

… test data - Delete GetGdiPlusIsAvailableNotWindows7 method (replaced with GetIsDrawingSupported) - Change SupportsIdna from abstract to virtual with default value true, remove overrides - Delete IsWindows8xOrLater property and replace all usages with IsWindows - Delete IsNotWindows7AndIsWindowsImplementation and replace with Helpers.IsWindowsImplementation - Delete IsWindows8OrLater property and replace with PlatformDetection.IsWindows - Remove Windows 7 specific comments from SslStreamSystemDefaultsTest - Delete Unicode_Win7 test data directory and remove from project files Co-authored-by: jkotas <[email protected]>

Delete #include <versionhelpers.h> from util_nodependencies.cpp since it's no longer needed after removing InitRunningOnVersionStatus() and IsWindows8OrGreater() usage Co-authored-by: jkotas <[email protected]>

MichalPetryka · 2026-01-06T21:06:57Z

Low. Changes are purely simplifications based on the invariant that Windows 7 is not supported. No functional behavior changes for supported platforms.

I know it's not officially supported but it might be worth it to make sure the cleanup doesn't cause any issues with running under Wine/Proton since a lot of apps rely on them, especially in gamedev.

jkotas · 2026-01-06T21:23:54Z

I know it's not officially supported but it might be worth it to make sure the cleanup doesn't cause any issues with running under Wine/Proton since a lot of apps rely on them, especially in gamedev.

We (the core .NET team) do not have capacity for this sort of validation. If you care about this, feel free to validate this and report any issue to Wine/Proton to fix.

src/coreclr/inc/utilcode.h

src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamSystemDefaultsTest.cs

Remove redundant case for SslPolicyErrors.RemoteCertificateNotAvailable since it returns false like the default case Co-authored-by: stephentoub <[email protected]>

jkotas · 2026-01-07T03:51:46Z

/ba-g deadletter

Initial plan

0847e36

Copilot AI assigned Copilot and jkotas Jan 5, 2026

Copilot started work on behalf of jkotas January 6, 2026 00:00 View session

Copilot AI and others added 4 commits January 6, 2026 00:33

Fix remaining IsWindows7 references in tests

90a0807

Co-authored-by: jkotas <[email protected]>

Address code review feedback: remove if (false) blocks and simplify c…

bfa7192

…onditionals Co-authored-by: jkotas <[email protected]>

Remove remaining if (false) blocks from test files

0b00a9e

Co-authored-by: jkotas <[email protected]>

Copilot AI changed the title ~~[WIP] Remove PlatformDetection.IsWindows7 and IsNotWindows7 properties~~ Remove PlatformDetection.IsWindows7 and IsNotWindows7 properties Jan 6, 2026

Copilot AI requested a review from jkotas January 6, 2026 00:43

Copilot finished work on behalf of jkotas January 6, 2026 00:43

jkotas reviewed Jan 6, 2026

View reviewed changes

src/coreclr/utilcode/util_nodependencies.cpp Outdated Show resolved Hide resolved

Copilot started work on behalf of jkotas January 6, 2026 01:25 View session

jkotas reviewed Jan 6, 2026

View reviewed changes

src/libraries/Common/tests/System/Drawing/Helpers.cs Outdated Show resolved Hide resolved

jkotas reviewed Jan 6, 2026

View reviewed changes

src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/PlatformHandlerTest.cs Outdated Show resolved Hide resolved

jkotas reviewed Jan 6, 2026

View reviewed changes

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs Outdated Show resolved Hide resolved

jkotas reviewed Jan 6, 2026

View reviewed changes

src/libraries/System.Net.HttpListener/tests/HttpListenerWebSocketTests.cs Outdated Show resolved Hide resolved

jkotas reviewed Jan 6, 2026

View reviewed changes

src/libraries/System.Net.HttpListener/tests/HttpListenerWebSocketTests.cs Outdated Show resolved Hide resolved

jkotas reviewed Jan 6, 2026

View reviewed changes

src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamSystemDefaultsTest.cs Outdated Show resolved Hide resolved

jkotas reviewed Jan 6, 2026

View reviewed changes

...raries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs Show resolved Hide resolved

jkotas reviewed Jan 6, 2026

View reviewed changes

src/tests/Interop/IJW/NativeCallingManaged/NativeCallingManaged.cs Outdated Show resolved Hide resolved

jkotas reviewed Jan 6, 2026

View reviewed changes

src/tests/Interop/IJW/ManagedCallingNative/ManagedCallingNative.cs Outdated Show resolved Hide resolved

jkotas and others added 2 commits January 5, 2026 17:38

Apply suggestions from code review

3e583fc

Remove RUNNING_ON_WIN7 enum value and update comments

c153f80

- Delete RUNNING_ON_WIN7 from RunningOnStatusEnum - Update RUNNING_ON_WIN8 value from 2 to 1 - Update comment to reflect Win8 as minimum supported platform Co-authored-by: jkotas <[email protected]>

Copilot AI requested a review from jkotas January 6, 2026 01:47

Copilot finished work on behalf of jkotas January 6, 2026 01:47

Copilot started work on behalf of jkotas January 6, 2026 01:48 View session

Copilot finished work on behalf of jkotas January 6, 2026 02:15

Copilot started work on behalf of jkotas January 6, 2026 02:49 View session

Remove unnecessary versionhelpers.h include

b466944

Delete #include <versionhelpers.h> from util_nodependencies.cpp since it's no longer needed after removing InitRunningOnVersionStatus() and IsWindows8OrGreater() usage Co-authored-by: jkotas <[email protected]>

Copilot AI requested a review from jkotas January 6, 2026 06:20

Copilot finished work on behalf of jkotas January 6, 2026 06:20

jkotas requested a review from jkoritzinsky January 6, 2026 06:25

Merge branch 'main' into copilot/remove-windows7-properties

e4b0214

jkotas approved these changes Jan 6, 2026

View reviewed changes

jkotas reviewed Jan 6, 2026

View reviewed changes

src/coreclr/inc/utilcode.h Show resolved Hide resolved

jkotas requested a review from stephentoub January 6, 2026 21:30

stephentoub approved these changes Jan 6, 2026

View reviewed changes

src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamSystemDefaultsTest.cs Outdated Show resolved Hide resolved

Copilot started work on behalf of stephentoub January 6, 2026 21:47 View session

Simplify ServerCertCallback switch statement

a03e2e1

Remove redundant case for SslPolicyErrors.RemoteCertificateNotAvailable since it returns false like the default case Co-authored-by: stephentoub <[email protected]>

Copilot AI requested a review from stephentoub January 6, 2026 22:08

Copilot finished work on behalf of stephentoub January 6, 2026 22:08

stephentoub approved these changes Jan 6, 2026

View reviewed changes

stephentoub enabled auto-merge (squash) January 6, 2026 22:13

stephentoub merged commit cadd41f into main Jan 7, 2026
143 of 147 checks passed

jkotas deleted the copilot/remove-windows7-properties branch January 7, 2026 03:52

This was referenced Jan 9, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#4125

Closed

[main] Source code updates from dotnet/runtime dotnet/dotnet#4196

Merged

github-actions bot locked and limited conversation to collaborators Feb 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove PlatformDetection.IsWindows7 and IsNotWindows7 properties#122907

Remove PlatformDetection.IsWindows7 and IsNotWindows7 properties#122907
stephentoub merged 20 commits intomainfrom
copilot/remove-windows7-properties

Copilot AI commented Jan 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MichalPetryka commented Jan 6, 2026

Uh oh!

jkotas commented Jan 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

jkotas commented Jan 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

Copilot AI commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Customer Impact

Regression

Testing

Risk

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MichalPetryka commented Jan 6, 2026

Uh oh!

jkotas commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas commented Jan 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Copilot AI commented Jan 5, 2026 •

edited

Loading

jkotas commented Jan 6, 2026 •

edited

Loading