Fix regression introduced by recent PR#122850
Conversation
Relax assert condition
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
|
Fixing test failures in outer loop, e.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=1242629&view=ms.vss-test-web.build-test-results-tab&runId=34586056&paneView=debug&resultId=120695 : |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR relaxes an assertion condition in the GetNormalizedIntegralArrayElementType method to fix a regression. The assertion is changed from checking a specific range of valid element types to checking that the element type value is less than 32.
Key Changes
- Replaced a range check assertion (
elementType >= Boolean && elementType <= Double) with a bounds check ((int)elementType < 32) - Added a comment explaining that the shift operator uses only the low-order five bits of the right-hand operand
|
/ba-g deadletter |
Relax assert condition