Skip to content

Fix MethodBase.GetCurrentMethod with runtime async#122710

Merged
eduardo-vp merged 3 commits intodotnet:mainfrom
eduardo-vp:fix-async-get-current-method
Dec 23, 2025
Merged

Fix MethodBase.GetCurrentMethod with runtime async#122710
eduardo-vp merged 3 commits intodotnet:mainfrom
eduardo-vp:fix-async-get-current-method

Conversation

@eduardo-vp
Copy link
Member

@eduardo-vp eduardo-vp commented Dec 23, 2025 •
edited
Loading

Fixes #122546.

The following code can now be Native AOT compiled and run with runtime-async enabled.

class Program
{
    static async Task Main()
    {
        Console.WriteLine("Hello world");
        await MyAsyncMethod();
    }

    static async Task MyAsyncMethod()
    {
        MethodBase currentMethod = MethodBase.GetCurrentMethod();
        Console.WriteLine($"Current method: {currentMethod?.Name}");
        await Task.Delay(100);
    }
}

Copilot AI review requested due to automatic review settings December 23, 2025 00:55
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Dec 23, 2025

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Copilot AI reviewed Dec 23, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to fix an issue where MethodBase.GetCurrentMethod() fails when called from within an async method in Native AOT compilation. The fix adds logic to handle async methods by unwrapping async method variants to get the original method definition before creating the reflection thunk.

Key Changes

  • Adds async method handling in the ExpandIntrinsicForCallsite method for MethodBase.GetCurrentMethod() intrinsic expansion
  • When the callsite is an async method, the code attempts to get the target of the async variant method before generating the thunk

MichalStrehovsky
MichalStrehovsky reviewed Dec 23, 2025
View reviewed changes
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need a test. Conveniently, a test already exists, we just need to remove ActiveIssue (the issue number is wrong):

runtime/src/tests/async/reflection/reflection.cs

Line 250 in c591f97

[ActiveIssue("https://github.com/dotnet/runtime/issues/122517", typeof(TestLibrary.Utilities), nameof(TestLibrary.Utilities.IsNativeAot))]

@eduardo-vp eduardo-vp merged commit 44e1a20 into dotnet:main Dec 23, 2025
104 checks passed
This was referenced Jan 9, 2026
Closed
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

Assignees

@eduardo-vp eduardo-vp

Labels

area-NativeAOT-coreclr runtime-async

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MethodBase.GetCurrentMethod with runtime async

3 participants

@eduardo-vp @MichalStrehovsky