Fix bug in superpmi scripts for determining jit name#122619
Closed
AndyAyersMS wants to merge 1 commit intodotnet:mainfrom
Closed
Fix bug in superpmi scripts for determining jit name#122619AndyAyersMS wants to merge 1 commit intodotnet:mainfrom
AndyAyersMS wants to merge 1 commit intodotnet:mainfrom
Conversation
github-actions
bot
added
the
area-CodeGen-coreclr
Member
Author
|
@adamperlin ptal Fixes issue noted in #122425 (comment) |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a control flow bug in the determine_jit_name function where the wasm target architecture check was incorrectly using if instead of elif, causing it to be evaluated independently rather than as part of the mutually exclusive conditional chain.
Key Changes
- Corrected the conditional chain for determining JIT OS name by changing
if target_arch.startswith("wasm")toelif target_arch.startswith("wasm")
adamperlin
added a commit
to adamperlin/runtime
that referenced
this pull request
Dec 17, 2025
Member
Author
|
We ended up pulling this into #122425 so it could be properly tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.