[clr-interp] Add logic to fix tail-call issues#122618
Merged
davidwrighton merged 1 commit intodotnet:mainfrom Dec 18, 2025
Merged
[clr-interp] Add logic to fix tail-call issues#122618davidwrighton merged 1 commit intodotnet:mainfrom
davidwrighton merged 1 commit intodotnet:mainfrom
Conversation
- Detect the case where tail calls are not immediately followed by ret, and fail the tail-call. - Detect the attempted usage of tail-calls from within synchronized methods or from within reverse p/invoke methods - Use the jit interface canTailCall api when a tail-call is requested - Enable tail-calls for calli instructions Update the TailcallVerifyWithPrefix test to skip tests which depend on the jit performing implicit tail-calls when optimizing when running under the interpreter This fixes the TailcallVerifyWithPrefix and more_tailcalls test
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
BrzVlad
approved these changes
Dec 18, 2025
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the TailcallVerifyWithPrefix test to skip tests which depend on the jit performing implicit tail-calls when optimizing when running under the interpreter
This fixes the TailcallVerifyWithPrefix and more_tailcalls test