Fix LibraryMode test to expect publish failure without WASM SDK#122615
Merged
maraf merged 3 commits intomaraf/BrowserLibraryModeNoWorkloadfrom Dec 17, 2025
Merged
Fix LibraryMode test to expect publish failure without WASM SDK#122615maraf merged 3 commits intomaraf/BrowserLibraryModeNoWorkloadfrom
maraf merged 3 commits intomaraf/BrowserLibraryModeNoWorkloadfrom
Conversation
…M SDK Co-authored-by: maraf <[email protected]>
Co-authored-by: maraf <[email protected]>
Copilot
AI
changed the title
[WIP] Fix test variant for library mode without workload
Fix LibraryMode test to expect publish failure without WASM SDK
Dec 17, 2025
maraf
approved these changes
Dec 17, 2025
5f80cfd
into
maraf/BrowserLibraryModeNoWorkload
12 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
LibraryModetest variant withuseWasmSdk: False, isPublish: Trueis expected to fail, but the test was asserting success for all variants.Updated test to set
ExpectSuccess: falsewhen publishing without WASM SDK, verifying the operation exits with code 1 as expected.Customer Impact
No customer impact - test-only change.
Regression
No. Test was incomplete, not validating the expected failure scenario.
Testing
Test compiles successfully. The updated test will properly validate all four variants:
Risk
Minimal - test-only change with no production code impact.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.