[RuntimeAsync] Removing TODO in methodtablebuilder.cpp. More robust insertion of methods.#122377
Merged
VSadov merged 12 commits intodotnet:mainfrom Dec 12, 2025
Merged
[RuntimeAsync] Removing TODO in methodtablebuilder.cpp. More robust insertion of methods.#122377VSadov merged 12 commits intodotnet:mainfrom
VSadov merged 12 commits intodotnet:mainfrom
Conversation
github-actions
bot
added
the
needs-area-label
VSadov
added
area-VM-coreclr
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @mangod9 |
VSadov
commented
Dec 10, 2025
This was referenced Dec 10, 2025
Open
jkotas
reviewed
Dec 10, 2025
Co-authored-by: VSadov <[email protected]>
Co-authored-by: VSadov <[email protected]>
Per @VSadov's feedback, replaced runtime type generation with actual source-defined classes containing 40k and 32k+ methods. Co-authored-by: VSadov <[email protected]>
VSadov
commented
Dec 11, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a TODO comment in methodtablebuilder.cpp and makes the insertion of async method variants more robust by implementing proper capacity management and bounds checking. The changes enable RuntimeAsync by default and add comprehensive tests to verify the new method capacity limits.
- Implements robust capacity doubling for async methods (up to MAX_SLOT_INDEX - 1 = 65524)
- Adds runtime bounds checking before method insertion to prevent array overflow
- Enables RuntimeAsync by default for CoreCLR and enables corresponding tests
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/vm/methodtablebuilder.cpp | Replaces conditional capacity doubling with robust upfront capacity calculation clamped to MAX_SLOT_INDEX - 1, and adds bounds check before method insertion to throw TypeLoadException when limit is exceeded |
| src/coreclr/utilcode/allocmemtracker.cpp | Increases consistency check threshold from 10,000 to 60,000 blocks to accommodate larger classes with up to 65,524 methods |
| src/coreclr/inc/clrconfigvalues.h | Enables RuntimeAsync feature by default (changes default value from 0 to 1) |
| src/tests/async/Directory.Build.targets | Removes the DisableProjectBuild condition to enable async tests for CoreCLR (non-nativeaot) builds |
| src/tests/async/capacity/capacity.csproj | Defines new test project structure including test file and three generated test class files |
| src/tests/async/capacity/capacity.cs | Adds three test scenarios: 40,000 int-returning methods (should succeed), 32,750 Task-returning methods (should succeed), and 32,763 Task-returning methods (should fail with TypeLoadException) |
jkotas
reviewed
Dec 11, 2025
jkotas
reviewed
Dec 11, 2025
Co-authored-by: Jan Kotas <[email protected]>
This reverts commit 6975252.
Member
Author
|
/ba-g failures in LibraryImportGenerator are all #122447 |
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #121760
To make the insertion of methods more robust we:
MethodDesc.Note: it may result in some programs that used to run to start throwing
TypeLoadException.These would be extreme cases though. The capacity for simple methods is implementation-specific. In CoreCLR a type cannot contain more than 65524 methods due to internal limitations.
(More complex cases involving inheritance/virtual methods may have additional limits.)
With runtime async, methods that return
Task/ValueTaskmay consume 2 methods instead of 1 from this 65524 budget.In a worst case where all methods return
Task, the limit becomes 32762 methods in a single type, which still seems a very high limit for reasonably real programs that are not generated testcases.