Merge CoreMangLib test suite#122314
Merged
jkoritzinsky merged 12 commits intodotnet:mainfrom Jan 5, 2026
Merged
Conversation
jkoritzinsky
added
test-enhancement
jkoritzinsky
requested review from
akoeplinger
and removed request for
Copilot
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
…art version number instead of a semver version
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates the CoreMangLib test suite by merging 57 individual test projects into a single unified test project, significantly reducing build complexity and maintenance overhead.
Key changes:
- Unified test project configuration in CoreMangLib.csproj that includes all C# test files and only IL projects
- Added
[OuterLoop]attributes to all test entry points to categorize long-running tests - Renamed generic class names (Program, TestClass) to unique names to avoid conflicts when merging
- Moved Environment.Version test from CoreMangLib to System.Runtime.Extensions.Tests with improved version checking mechanism
- Fixed thread cleanup issues in RefStructWithSpan.cs by adding proper termination signaling
Reviewed changes
Copilot reviewed 114 out of 114 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| CoreMangLib.csproj | Modified to merge all test projects - now includes all C# files directly and only references IL projects |
| system/type/*.cs | Added [OuterLoop] attributes and renamed TestClass to unique names to avoid conflicts |
| system/threading/interlocked/*.cs | Added [OuterLoop] attributes to test entry points |
| system/span/SlowTailCallArgs.cs | Renamed class from Program to SlowTailCallArgs, added conditional and platform-specific attributes |
| system/span/RefStructWithSpan.cs | Fixed infinite loops in background threads by adding TestComplete flag and proper thread joining |
| system/runtime/interopservices/safehandle/*.cs | Added [OuterLoop] attributes |
| system/runtime/interopservices/marshal/*.cs | Added [OuterLoop] attributes |
| system/reflection/emit/DynMethodJumpStubTests.cs | Replaced project-level conditions with conditional class attributes and platform-specific test attributes |
| system/multicastdelegate/*.cs | Added [OuterLoop] attributes |
| system/environment/environment_version.cs | Deleted - functionality moved to System.Runtime.Extensions.Tests |
| system/enum/*.cs | Added [OuterLoop] attributes |
| system/delegate/regressions/**/*.cs | Renamed Program to specific class names, added [OuterLoop] and conditional attributes |
| system/delegate/miscellaneous/*.cs | Renamed generic class names, added [OuterLoop] attributes |
| system/delegate/generics/*.cs | Added [OuterLoop] attributes |
| system/delegate/delegate/*.cs | Renamed TestClass occurrences to unique names, added [OuterLoop] attributes |
| system/delegate/VSD/OpenDelegate.cs | Renamed Program to OpenDelegate, added [OuterLoop] attribute |
| system/buffer/asurt_99893.cs | Added [OuterLoop] attribute |
| System.Runtime.Extensions.Tests/EnvironmentTests.cs | Modified Version_Valid test to use AppContext configuration for expected version |
| System.Runtime.Extensions.Tests.csproj | Added RuntimeHostConfigurationOption to pass AssemblyVersion to tests |
| /*.csproj (57 files) | Deleted - individual test projects consolidated into main CoreMangLib.csproj |
| ClosedStatic.reflect.xml | Deleted - reflect configuration no longer needed in merged structure |
src/tests/CoreMangLib/system/delegate/miscellaneous/co6010delegateequalstwo.cs
Outdated
Show resolved
Hide resolved
src/tests/CoreMangLib/system/delegate/miscellaneous/co6010delegateequalstwo.cs
Outdated
Show resolved
Hide resolved
src/tests/CoreMangLib/system/delegate/miscellaneous/co6010delegateequalstwo.cs
Outdated
Show resolved
Hide resolved
jkoritzinsky
commented
Dec 11, 2025
src/tests/CoreMangLib/system/delegate/miscellaneous/co6010delegateequalstwo.cs
Outdated
Show resolved
Hide resolved
This was referenced Dec 12, 2025
Open
jkoritzinsky
commented
Dec 15, 2025
jkoritzinsky
commented
Dec 16, 2025
.../System.Runtime/tests/System.Runtime.Extensions.Tests/System.Runtime.Extensions.Tests.csproj
Outdated
Show resolved
Hide resolved
3 tasks
hoyosjs
approved these changes
Jan 5, 2026
Member
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/ba-g outerloop failures are unrelated and tracked, but BA won't go green because the iOS job timed out weeks ago. |
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests can all easily be part of one test project.
Removes 56 csproj files.