Removing unnecessary conditional check#122271
Merged
jkotas merged 1 commit intodotnet:mainfrom Dec 7, 2025
Merged
Conversation
Removed preprocessor directive for ArgumentNullException check.
dotnet-policy-service
bot
added
the
community-contribution
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an unnecessary preprocessor conditional around an ArgumentNullException.ThrowIfNull call in the TimeProvider class. The conditional compilation directive was redundant because both the SYSTEM_PRIVATE_CORELIB and non-SYSTEM_PRIVATE_CORELIB branches contained identical code.
Key Changes
- Simplified the
CreateTimermethod by removing duplicate conditional compilation directives - No behavioral change - the same null check is now unconditionally applied
jkotas
added
area-System.DateTime
and removed
needs-area-label
jkotas
approved these changes
Dec 7, 2025
Member
|
/ba-g insufficient info in logs - timeout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed preprocessor directive for ArgumentNullException check.