Fix Type.IsVisible and Type.ContainsGenericParameters for function pointers by Copilot · Pull Request #122224 · dotnet/runtime

Copilot · 2025-12-05T14:04:42Z

Understand the issue: Type.IsVisible and Type.ContainsGenericParameters don't handle function pointers correctly
Modify ContainsGenericParameters in Type.Helpers.cs to check function pointer return and parameter types
Modify IsVisible in Type.Helpers.cs to check function pointer return and parameter types
Add tests for function pointer visibility with private types
Add tests for function pointer ContainsGenericParameters with generic types
Build and test the changes
Run code review and address feedback
Run CodeQL checker

Original prompt

This section details on the original issue you should resolve

<issue_title>Abstract implementations of Type.IsVisible and Type.ContainsGenericParameters do not handle function pointers</issue_title>
<issue_description>### Description

Abstract implementations of Type.IsVisible and Type.ContainsGenericParameters do not handle function pointers

Reproduction Steps
unsafe
{
    Console.WriteLine(typeof(delegate* <string>).IsVisible);
    Console.WriteLine(typeof(delegate* <PrivateType>).IsVisible);
}


class PrivateType { }
Expected behavior

true false with dotnet run (correct).

Actual behavior

true true with PublishAot=true

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response</issue_description>

<agent_instructions>Handle function pointers in these two methods in Type.Helpers.cs. Make sure to add tests</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes Abstract implementations of Type.IsVisible and Type.ContainsGenericParameters do not handle function pointers #122223

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…rameters Co-authored-by: jkotas <[email protected]>

Co-authored-by: jkotas <[email protected]>

dotnet-policy-service · 2025-12-05T14:49:22Z

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

jkotas · 2025-12-05T14:49:40Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-12-05T14:49:49Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

This PR fixes bugs in the abstract implementations of Type.IsVisible and Type.ContainsGenericParameters that caused incorrect results for function pointer types in NativeAOT.

Key Changes:

Added function pointer handling to ContainsGenericParameters to check return and parameter types
Added function pointer handling to IsVisible to validate visibility of return and parameter types
Added comprehensive test coverage for function pointer visibility scenarios

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/libraries/System.Private.CoreLib/src/System/Type.Helpers.cs	Adds function pointer checks to `ContainsGenericParameters` and `IsVisible` properties to recursively validate return and parameter types
src/libraries/Common/tests/System/FunctionPointerTests.cs	Adds `FunctionPointerVisibility` test with scenarios for public/private return types and parameters, plus supporting test fields in `FunctionPointerHolder`

src/libraries/Common/tests/System/FunctionPointerTests.cs

Co-authored-by: jkotas <[email protected]>

src/libraries/Common/tests/System/FunctionPointerTests.cs

Co-authored-by: jkotas <[email protected]>

src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Type/TypeTests.cs

…/Type/TypeTests.cs

…o inherit from Type directly Co-authored-by: jkotas <[email protected]>

src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Type/TypeTests.cs

…ericParameters Co-authored-by: jkotas <[email protected]>

src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Type/TypeTests.cs

Initial plan

439789c

Copilot AI assigned Copilot and jkotas Dec 5, 2025

Copilot started work on behalf of jkotas December 5, 2025 14:05 View session

Copilot AI and others added 2 commits December 5, 2025 14:37

Handle function pointers in Type.IsVisible and Type.ContainsGenericPa…

6581c99

…rameters Co-authored-by: jkotas <[email protected]>

Add comments explaining pragma warning suppressions

4fc5f7a

Co-authored-by: jkotas <[email protected]>

Copilot AI changed the title ~~[WIP] Fix Type.IsVisible and Type.ContainsGenericParameters for function pointers~~ Fix Type.IsVisible and Type.ContainsGenericParameters for function pointers Dec 5, 2025

Copilot AI requested a review from jkotas December 5, 2025 14:44

Copilot finished work on behalf of jkotas December 5, 2025 14:45

jkotas added the area-System.Reflection label Dec 5, 2025

jkotas marked this pull request as ready for review December 5, 2025 14:48

Copilot AI review requested due to automatic review settings December 5, 2025 14:48

Copilot started reviewing on behalf of jkotas December 5, 2025 14:49 View session

Copilot finished reviewing on behalf of jkotas December 5, 2025 14:50

Copilot AI reviewed Dec 5, 2025

View reviewed changes

jkotas reviewed Dec 5, 2025

View reviewed changes

src/libraries/Common/tests/System/FunctionPointerTests.cs Show resolved Hide resolved

Copilot started work on behalf of jkotas December 5, 2025 17:40 View session

Add FunctionPointerContainsGenericParameters test

8398c7e

Co-authored-by: jkotas <[email protected]>

build-analysis bot mentioned this pull request Dec 5, 2025

System.Security.Cryptography.Tests .IsSupported_AgreesWithPlatform failures #122228

Closed

Copilot AI requested a review from jkotas December 5, 2025 18:06

Copilot finished work on behalf of jkotas December 5, 2025 18:06

build-analysis bot mentioned this pull request Dec 5, 2025

Test failure BasicEventSourceTests.TestsUserErrors.Test_BadEventSource_MismatchedIds_WithEtwListener #96968

Open

jkotas reviewed Dec 6, 2025

View reviewed changes

src/libraries/Common/tests/System/FunctionPointerTests.cs Outdated Show resolved Hide resolved

Update src/libraries/Common/tests/System/FunctionPointerTests.cs

8fd4aae

Copilot started work on behalf of jkotas December 6, 2025 05:31 View session

Changes before error encountered

1ff1d03

Co-authored-by: jkotas <[email protected]>

Copilot AI requested a review from jkotas December 6, 2025 05:58

Copilot started work on behalf of jkotas December 7, 2025 00:07 View session

jkotas reviewed Dec 7, 2025

View reviewed changes

src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Type/TypeTests.cs Outdated Show resolved Hide resolved

jkotas and others added 2 commits December 6, 2025 16:08

Update src/libraries/System.Runtime/tests/System.Runtime.Tests/System…

d1d1ae4

…/Type/TypeTests.cs

Remove IsFunctionPointer assertions and fix MockFunctionPointerType t…

c722924

…o inherit from Type directly Co-authored-by: jkotas <[email protected]>

Copilot AI requested a review from jkotas December 7, 2025 00:31

Copilot finished work on behalf of jkotas December 7, 2025 00:31

jkotas reviewed Dec 7, 2025

View reviewed changes

src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Type/TypeTests.cs Outdated Show resolved Hide resolved

Copilot started work on behalf of jkotas December 7, 2025 00:35 View session

Rename MockFunctionPointerType to MockFunctionPointerType_ContainsGen…

2d1a8f0

…ericParameters Co-authored-by: jkotas <[email protected]>

Copilot AI requested a review from jkotas December 7, 2025 00:57

Copilot finished work on behalf of jkotas December 7, 2025 00:57

jkotas approved these changes Dec 7, 2025

View reviewed changes

jkotas requested a review from AaronRobinsonMSFT December 7, 2025 00:59

stephentoub reviewed Dec 7, 2025

View reviewed changes

src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Type/TypeTests.cs Show resolved Hide resolved

Copilot started work on behalf of stephentoub December 7, 2025 13:17 View session

stephentoub approved these changes Dec 7, 2025

View reviewed changes

Copilot AI requested a review from stephentoub December 7, 2025 13:38

Copilot finished work on behalf of stephentoub December 7, 2025 13:38

stephentoub enabled auto-merge (squash) December 7, 2025 13:41

stephentoub merged commit 3114f8e into main Dec 7, 2025
137 of 142 checks passed

jkotas deleted the copilot/fix-function-pointer-visibility branch December 7, 2025 15:59

This was referenced Dec 8, 2025

[main] Source code updates from dotnet/runtime dotnet/dotnet#3725

Closed

[main] Source code updates from dotnet/runtime dotnet/dotnet#3766

Closed

maestro-local-dev bot mentioned this pull request Dec 10, 2025

[repro/d7f049ef-d337-4132-bc67-a9d2b6ecd9a8] Source code updates from maestro-auth-test/runtime maestro-auth-test/dotnet#234

Closed

dotnet-maestro bot mentioned this pull request Dec 13, 2025

[main] Source code updates from dotnet/runtime dotnet/dotnet#3873

Merged

github-actions bot locked and limited conversation to collaborators Jan 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Type.IsVisible and Type.ContainsGenericParameters for function pointers#122224

Fix Type.IsVisible and Type.ContainsGenericParameters for function pointers#122224
stephentoub merged 11 commits intomainfrom
copilot/fix-function-pointer-visibility

Copilot AI commented Dec 5, 2025 •

edited

Loading

Uh oh!

dotnet-policy-service bot commented Dec 5, 2025

Uh oh!

jkotas commented Dec 5, 2025

Uh oh!

azure-pipelines bot commented Dec 5, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reproduction Steps

Expected behavior

Actual behavior

Regression?

Known Workarounds

Configuration

Other information

Comments on the Issue (you are @copilot in this section)

Uh oh!

dotnet-policy-service bot commented Dec 5, 2025

Uh oh!

jkotas commented Dec 5, 2025

Uh oh!

azure-pipelines bot commented Dec 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Dec 5, 2025 •

edited

Loading