Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Dec 4, 2025

Backport of #120736 to release/8.0

/cc @rzikm

Customer Impact

None, the change is in Debug build only and doesn't affect shipped product.

Regression

No, test failures started after adding/updating AzureLinux3 OS in CI matrix.

Testing

CI passes.

Risk

Low, can be considered test-only change as the changes don't propagate to shipped product.

@wfurt
Copy link
Member

wfurt commented Dec 4, 2025

Do we need separate approval or was it covered by the one for 9.0/10.10? And should this be release/8.0 r release/8.0-staging?

@agocke agocke added the Servicing-approved Approved for servicing release label Dec 4, 2025
@agocke
Copy link
Member

agocke commented Dec 4, 2025

Tell mode, we're good to go when tests pass.

@agocke agocke enabled auto-merge (squash) December 4, 2025 20:02
@rzikm
Copy link
Member

rzikm commented Dec 5, 2025

/ba-g Test failures around X509Certificates are unrelated

@agocke agocke merged commit 103b56e into release/8.0 Dec 5, 2025
170 of 179 checks passed
@rzikm
Copy link
Member

rzikm commented Dec 5, 2025

Do we need separate approval or was it covered by the one for 9.0/10.10? And should this be release/8.0 r release/8.0-staging?

It should be release/8.0-staging (facepalm), and it got automerged so I noticed too late

@ViktorHofer what should we do in this case?

@jozkee
Copy link
Member

jozkee commented Dec 5, 2025

what should we do in this case?

@rzikm nothing, staging is there just to let authors merge their own changes without having to wait for folks with admin permissions.

Keep targeting staging in the future since that will test your change with all other changes in the release. Of course, this does not apply for 10.0 servicing.

@jkotas jkotas deleted the backport/pr-120736-to-release/8.0 branch December 7, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants