[release/8.0-staging] replace SLES test queue with Docker alternative #122155
Conversation
wfurt
changed the title
There was a problem hiding this comment.
Pull request overview
This PR replaces the dedicated SLES (SUSE Linux Enterprise Server) test queue with a Docker-based alternative using openSUSE 15.6 containers. The change aims to simplify maintenance by retiring the dedicated SLES queue infrastructure in favor of containerized testing, consistent with similar changes already made on the main branch.
Key Changes:
- Replace
SLES.15.Amd64.Openqueue with openSUSE 15.6 Docker container for mono outerloop tests - Replace
SLES.15.Amd64.Openqueue with openSUSE 15.6 Docker container for extra platforms testing
| - ${{ if or(ne(parameters.jobParameters.testScope, 'outerloop'), ne(parameters.jobParameters.runtimeFlavor, 'mono')) }}: | ||
| - ${{ if or(eq(parameters.jobParameters.isExtraPlatforms, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}: | ||
| - SLES.15.Amd64.Open | ||
| - (openSUSE.15.6.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:opensuse-15.6-helix-amd64 |
There was a problem hiding this comment.
Duplicate openSUSE entry detected. Both line 69 and line 75 define openSUSE.15.6 containers within the same conditional block (isExtraPlatforms=true OR includeAllPlatforms=true). This will result in the same distribution being tested twice when this condition is met.
If line 75 was intended to be the replacement for the old SLES entry, then line 69 should be removed. Otherwise, clarify if running openSUSE tests twice with different host queues is intentional.
| - (openSUSE.15.6.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:opensuse-15.6-helix-amd64 |
| - ${{ if and(eq(parameters.jobParameters.interpreter, ''), ne(parameters.jobParameters.isSingleFile, true)) }}: | ||
| - ${{ if and(eq(parameters.jobParameters.testScope, 'outerloop'), eq(parameters.jobParameters.runtimeFlavor, 'mono')) }}: | ||
| - SLES.15.Amd64.Open | ||
| - (openSUSE.15.6.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:opensuse-15.6-helix-amd64 |
There was a problem hiding this comment.
Inconsistent host queue name used for openSUSE container. Line 62 uses AzureLinux.3.Amd64.open as the host queue, but line 75 (another openSUSE entry in the same file) uses Ubuntu.2204.amd64.open. Additionally, line 74 shows that AzureLinux entries use the pattern AzureLinux.3.0.Amd64.Open (with version "3.0" and capital "Open"), not AzureLinux.3.Amd64.open.
Consider using Ubuntu.2204.amd64.open for consistency with line 75, or if AzureLinux is intended, use AzureLinux.3.0.Amd64.Open to match the pattern on line 74.
| - (openSUSE.15.6.Amd64.Open)AzureLinux.3.Amd64[email protected]/dotnet-buildtools/prereqs:opensuse-15.6-helix-amd64 | |
| - (openSUSE.15.6.Amd64.Open)Ubuntu.2204.amd64[email protected]/dotnet-buildtools/prereqs:opensuse-15.6-helix-amd64 |
| - ${{ if or(ne(parameters.jobParameters.testScope, 'outerloop'), ne(parameters.jobParameters.runtimeFlavor, 'mono')) }}: | ||
| - ${{ if or(eq(parameters.jobParameters.isExtraPlatforms, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}: | ||
| - SLES.15.Amd64.Open | ||
| - (openSUSE.15.6.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:opensuse-15.6-helix-amd64 |
There was a problem hiding this comment.
Inconsistent host queue name used for openSUSE container. Line 69 uses AzureLinux.3.Amd64.open as the host queue, but line 75 (another openSUSE entry in the same file) uses Ubuntu.2204.amd64.open. Additionally, line 74 shows that AzureLinux entries use the pattern AzureLinux.3.0.Amd64.Open (with version "3.0" and capital "Open"), not AzureLinux.3.Amd64.open.
Consider using Ubuntu.2204.amd64.open for consistency with line 75, or if AzureLinux is intended, use AzureLinux.3.0.Amd64.Open to match the pattern on line 74.
| - (openSUSE.15.6.Amd64.Open)AzureLinux.3.Amd64[email protected]/dotnet-buildtools/prereqs:opensuse-15.6-helix-amd64 | |
| - (openSUSE.15.6.Amd64.Open)Ubuntu.2204.amd64[email protected]/dotnet-buildtools/prereqs:opensuse-15.6-helix-amd64 |
|
closing in favor of #115502 |
1 participant
This mimics changes from main. It will allow us to retire maintenance of dedicated SLES queue. It seems like the container approach should be sufficient and in general it is much easier to maintain in our docker repo.
This is test only change.