Fix TypeMap test to match trimming spec#121937
Merged
MichalStrehovsky merged 2 commits intodotnet:mainfrom Nov 25, 2025
Merged
Conversation
github-actions
bot
added
the
needs-area-label
MichalStrehovsky
added
area-System.Runtime.InteropServices
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @dotnet/interop-contrib |
AaronRobinsonMSFT
approved these changes
Nov 24, 2025
Member
AaronRobinsonMSFT
left a comment
AaronRobinsonMSFT
left a comment
There was a problem hiding this comment.
Minor request for a doc link. Other than that, looks great!
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the TypeMap test to align with trimming specifications by replacing static typeof() calls with runtime .GetType() calls on instances. This change is significant for trimming scenarios where static type references created by typeof() must be preserved by the trimmer, while .GetType() calls on instances allow more flexible handling.
- Replaces
typeof(T)with instance creation followed by.GetType()for most type lookups in proxy type mapping tests - Preserves
typeof()usage for cases where instantiation is not possible (open generic types and pointer types) - Maintains existing
typeof()usage inTryGetValueassertions where static type references are required for the test logic
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #121912