Skip to content

[release/10.0] Fix source map URLs for .NET 10 VMR builds#121926

Merged
lewing merged 1 commit intorelease/10.0from
fix-sourcemap-url
Nov 26, 2025
Merged

[release/10.0] Fix source map URLs for .NET 10 VMR builds#121926
lewing merged 1 commit intorelease/10.0from
fix-sourcemap-url

Conversation

@akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Nov 24, 2025

Backport of #121923

Customer Impact

.NET 10 builds from the VMR (dotnet/dotnet) instead of dotnet/runtime. Source maps generated during CI builds were pointing to the old repository, causing 404 errors when browser debuggers attempted to load TypeScript sources.

Regression

  • Yes
  • No

This regressed when the official runtime build moved to happen in the VMR.

Testing

Local testing to make sure the correct URL is produced.

Risk

Low. This only affects debugging scenarios.

Copilot AI review requested due to automatic review settings November 24, 2025 15:35
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 24, 2025
@akoeplinger akoeplinger added Servicing-consider Issue for next servicing release review arch-wasm WebAssembly architecture area-Build-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 24, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes source map URLs for .NET 10 builds to point to the new VMR (Virtual Monolithic Repository) structure. When browser debuggers attempt to load TypeScript sources during debugging, they were receiving 404 errors because the URLs pointed to the old dotnet/runtime repository instead of the new dotnet/dotnet repository.

Key changes:

  • Updated the source map URL generation to use the dotnet/dotnet repository with the appropriate path prefix /src/runtime/

@rbhanda rbhanda added this to the 10.0.2 milestone Nov 24, 2025
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 24, 2025
@akoeplinger
Copy link
Member Author

/ba-g failures in WasmBuildTests are unrelated

@revbones-dev
Copy link

Is there a workaround or timeframe to receive this?

@lewing lewing merged commit baf4eb1 into release/10.0 Nov 26, 2025
45 of 55 checks passed
@akoeplinger akoeplinger deleted the fix-sourcemap-url branch November 26, 2025 18:05
@akoeplinger
Copy link
Member Author

@revbones-dev it will be released with 10.0.2.

In the meantime you could manually update the URLs similar to what I do in this PR in the dotnet.runtime.js.map and dotnet.js.map files in the wwwroot/_framework folder in the output folder and do a hard refresh.

@pavelsavara
Copy link
Member

pavelsavara commented Dec 15, 2025

Edit: maybe this is OK, because the preview bits are built from internal repo with different hash.

I was validating this by looking at the Microsoft.NETCore.App.Runtime.Mono.browser-wasm.10.0.2.nupkg of the preview binaries.

It contains file runtimes\browser-wasm\native\dotnet.diagnostics.js.map contains link to
https://raw.githubusercontent.com/dotnet/dotnet/a2aab71e7e1038d6304a5e1675c39392ced29691/src/runtime/src/mono/browser/runtime/diagnostics/logging.ts

But that resolves to HTTP 404.

This is likely because it was built from local commit that was not pushed to github. Or it’s githash from another repository.
Changing the hash in the URL to last hash on https://github.com/dotnet/dotnet/commits/release/10.0.102/ makes it work.

https://raw.githubusercontent.com/dotnet/dotnet/a1b9d991e4596823841f4f9d840e72ac369e3a7e/src/runtime/src/mono/browser/runtime/diagnostics/logging.ts

I think this is not critical enough to stop 10.0.2 rollout, but it would be nice to fix eventually.

@akoeplinger
Copy link
Member Author

akoeplinger commented Dec 15, 2025

Yes that's expected right now, we'll merge the internal branch to public shortly after release and then the commit will resolve.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Build-mono Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants