[release/10.0] Fix source map URLs for .NET 10 VMR builds#121926
[release/10.0] Fix source map URLs for .NET 10 VMR builds#121926lewing merged 1 commit intorelease/10.0from
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes source map URLs for .NET 10 builds to point to the new VMR (Virtual Monolithic Repository) structure. When browser debuggers attempt to load TypeScript sources during debugging, they were receiving 404 errors because the URLs pointed to the old dotnet/runtime repository instead of the new dotnet/dotnet repository.
Key changes:
- Updated the source map URL generation to use the dotnet/dotnet repository with the appropriate path prefix
/src/runtime/
|
/ba-g failures in WasmBuildTests are unrelated |
|
Is there a workaround or timeframe to receive this? |
|
@revbones-dev it will be released with 10.0.2. In the meantime you could manually update the URLs similar to what I do in this PR in the |
|
Edit: maybe this is OK, because the preview bits are built from internal repo with different hash. I was validating this by looking at the Microsoft.NETCore.App.Runtime.Mono.browser-wasm.10.0.2.nupkg of the preview binaries. It contains file runtimes\browser-wasm\native\dotnet.diagnostics.js.map contains link to But that resolves to HTTP 404. This is likely because it was built from local commit that was not pushed to github. Or it’s githash from another repository. I think this is not critical enough to stop 10.0.2 rollout, but it would be nice to fix eventually. |
|
Yes that's expected right now, we'll merge the internal branch to public shortly after release and then the commit will resolve. |
Backport of #121923
Customer Impact
.NET 10 builds from the VMR (dotnet/dotnet) instead of dotnet/runtime. Source maps generated during CI builds were pointing to the old repository, causing 404 errors when browser debuggers attempted to load TypeScript sources.
Regression
This regressed when the official runtime build moved to happen in the VMR.
Testing
Local testing to make sure the correct URL is produced.
Risk
Low. This only affects debugging scenarios.