Fix IsAsyncCall definition#121814
Merged
MichalStrehovsky merged 2 commits intodotnet:mainfrom Nov 20, 2025
Merged
Conversation
The implementation didn't match the comment.
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a logic bug in the IsAsyncCall method where the implementation didn't match its documentation. The method is supposed to return true for two distinct cases: (1) async variants (compiler-generated wrappers), and (2) special async intrinsics that use async calling convention but don't return Task/ValueTask.
Key Changes
- Reordered the boolean expression to check
IsAsyncVariant()first without requiring theIsAsyncflag - The
IsAsyncflag is now only required for the second case (async intrinsics that don't return Task/ValueTask)
jkotas
approved these changes
Nov 19, 2025
jtschuster
approved these changes
Nov 19, 2025
Member
Author
|
The failure in the x64 checked legs looks like what #121759 is fixing so we'll need to approve and merge that one first. |
MichalStrehovsky
added a commit
that referenced
this pull request
Nov 24, 2025
With #121814 merged we should be able to start running these in the CI for native AOT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation didn't match the comment.
cc @dotnet/ilc-contrib